Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(linting): restore eslint rules #795

Merged
merged 2 commits into from
Jul 31, 2020
Merged

build(linting): restore eslint rules #795

merged 2 commits into from
Jul 31, 2020

Conversation

jcfranco
Copy link
Member

Related Issue: #791

Summary

Restores the severity of the following rules to "error:

  • @stencil/ban-exported-const-enums
  • @stencil/strict-mutable
  • @typescript-eslint/no-inferrable-types
  • @typescript-eslint/no-use-before-define
  • lines-between-class-members
  • no-var
  • prefer-const

@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. chore Issues with changes that don't modify src or test files. labels Jul 31, 2020
@jcfranco jcfranco added this to the 🔨 v1-beta.37 milestone Jul 31, 2020
@jcfranco jcfranco requested a review from a team as a code owner July 31, 2020 15:19
@jcfranco jcfranco self-assigned this Jul 31, 2020
driskull
driskull approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 7739e84 into master Jul 31, 2020
@jcfranco jcfranco deleted the jcfranco/restore-eslint-rules branch July 31, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@paulcpederson paulcpederson Awaiting requested review from paulcpederson

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
v1.0.0-beta.37
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull