chore(linting): drop TSLint #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replaces prefer-conditional-expression rule with unicorn/prefer-ternary * removes remaining tslint-stencil rules used to warn about component/lifecycle order
jcfranco
added
the
chore
driskull
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #791
Summary
Removes TSLint since it was only set up for 3 rules:
prefer-conditional-expression– replaced byunicorn/prefer-ternary(fixable)component-member-order– fromtslint-stencil†lifecycle-order– fromtslint-stencil†† the
tslint-stencilrules have no equivalent at the moment, but I'll work on porting them for consistency. Their removal shouldn't affect us as they were used to warn about component/lifecycle order.