Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-input-time-picker - Add support for fractional seconds #6591

Closed
richiecarmichael opened this issue Mar 14, 2023 · 11 comments
Closed

calcite-input-time-picker - Add support for fractional seconds #6591

richiecarmichael opened this issue Mar 14, 2023 · 11 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2023 August Prior...

Comments

@richiecarmichael
Copy link

richiecarmichael commented Mar 14, 2023 •
edited
Loading

Description

The calcite-input-time-picker needs to be extended to support milliseconds. Specifically the component needs an option to include milliseconds in the display and also an editing experience.

image

Perhaps:

<calcite-input-time-picker fractionalSecondDigits=3 value="13:07:04.102" />

Acceptance Criteria

  • Add flag to calcite-input-time-picker to support millisecond display and editing
  • Allow user to edit milliseconds

Relevant Info

No response

Which Component

<calcite-input-time-picker />

Example Use Case

No response

Esri team

ArcGIS Maps SDK for JavaScript

Reference

  1. JSAPI - Enhancement - Editor- Support New Date Fields (see #50595)
  2. JSAPI - Enhancement - FeatureTable - Support New Date Fields (see #50596)
@richiecarmichael richiecarmichael added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Mar 14, 2023
@github-actions github-actions bot added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label Mar 14, 2023
@geospatialem geospatialem mentioned this issue Mar 16, 2023
Closed
@geospatialem
Copy link
Member

This request is a requirement of the Maps SDK for JavaScript to support new date fields throughout the ArcGIS ecosystem - should be paired with the creation of a new component from #6590.

@eriklharper eriklharper mentioned this issue Mar 31, 2023
Open
1 task
This was referenced Apr 6, 2023
Open
Open
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. and removed 0 - new New issues that need assignment. labels Apr 6, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. labels Apr 6, 2023
@ashetland
Copy link

Tagging this for necessary updates to Figma component. cc @SkyeSeitz

@geospatialem geospatialem added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Apr 19, 2023
@richiecarmichael
Copy link
Author

Just updated the proposed design:

From:

<calcite-input-time-picker showMilliseconds=true value="13:07:04.102" />

To:

<calcite-input-time-picker fractionalSecondDigits=3 value="13:07:04.102" />

...to align with Intl's fractionalSecondDigits property. This provides greater control (i.e. tenth, hundredth or thousandth of a second) depending on the precision of the data.

fractionalSecondDigits (on MDN) states that valid values are 0, 1, 2 and 3. However that this differs from ES2021 which only allows undefined, 1, 2 and 3. This discrepancy is logged and backlogged here. I would suggest using values 0, 1, 2 and 3.

@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Apr 24, 2023
@SkyeSeitz
Copy link

Design specs complete and available at the links below.
Time Picker: https://www.figma.com/file/fBkmuAy3R4BfjAWlRi2KjS/Calcite-Web-UI-Kit?node-id=10501%3A265212&t=6m3XXmjynq4AoQio-1
Input Time Picker: https://www.figma.com/file/fBkmuAy3R4BfjAWlRi2KjS/Calcite-Web-UI-Kit?node-id=12360%3A246650&t=6m3XXmjynq4AoQio-1

@geospatialem
Copy link
Member

Reallocating to the May milestone, where it is expected to land soon for additional texting in next.

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 9, 2023
@ubatsukh
Copy link

@jcfranco we will not using this component at 4.27 as we decided to only support read-only versions of the new date/time fields at 4.27. However, we will pick up this component as soon as the 4.27 is released.

You can find the general updates on adding support for new date/time fields from this planning doc issue: https://devtopia.esri.com/WebGIS/arcgis-js-api-planning-docs/issues/287#issue-1369706

@geospatialem
Copy link
Member

Reallocated to the upcoming July milestone per the discussion above.

@geospatialem
Copy link
Member

Reallocated to the August milestone with the UC approaching and addressing critical bugs in next week's June patch release.

@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels Jun 21, 2023
@jcfranco jcfranco assigned eriklharper and unassigned jcfranco Jun 21, 2023
@jcfranco
Copy link
Member

Passing the torch to @eriklharper for this one. 🔥🔥🔥

@geospatialem geospatialem mentioned this issue Jul 31, 2023
Open
@ashetland ashetland mentioned this issue Aug 1, 2023
Open
3 tasks
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 3, 2023
@eriklharper eriklharper mentioned this issue Aug 15, 2023
Merged
@eriklharper eriklharper changed the title calcite-input-time-picker - Add support for milliseconds calcite-input-time-picker - Add support for fractional seconds Aug 15, 2023
eriklharper added a commit that referenced this issue Aug 31, 2023
@eriklharper
feat(input-time-picker): support fractional seconds (#7532)
c2bf34b 
**Related Issue:** #6591 

## Summary

This PR adds initial support for fractional seconds in
`input-time-picker` and `time-picker` components. Both
`input-time-picker` and `time-picker` officially support fractional step
values from `.001` to `.9`.

---------

Co-authored-by: Erik Harper <[email protected]>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 31, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 31, 2023
@geospatialem
Copy link
Member

Verified in 1.7.0-next.17 with the following:

<calcite-input-time-picker step="0.1" value="10:37:09.5"></calcite-input-time-picker>

@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 27, 2023
@brittneytewks brittneytewks added the design Issues that need design consultation prior to development. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 August Priorities
Development

No branches or pull requests
8 participants
@jcfranco @eriklharper @richiecarmichael @ubatsukh @geospatialem @SkyeSeitz @ashetland @brittneytewks