Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add input masking to input-time-picker #2709

Open
AdelheidF opened this issue Aug 3, 2021 · 10 comments
Open

Enhancement: Add input masking to input-time-picker #2709

AdelheidF opened this issue Aug 3, 2021 · 10 comments
Assignees
@eriklharper
Labels
2 - in development Issues that are actively being worked on. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2025-02-25 - Feb ...

Comments

@AdelheidF
Copy link

AdelheidF commented Aug 3, 2021 •
edited by geospatialem
Loading

Description

Create a new calcite-input-time component to be used by calcite-input-time-picker to solve issues #2331 and #2329

Repurposing this issue

Let's add input masking to the input-time-picker component to support time selections without a picker.

Blocked issues: #8859

From @eriklharper

I discussed this with @jcfranco and we came up with the idea to create a new calcite-input-time component that will replace the current input box inside calcite-input-time-picker which will be modeled after the native browser implementations like this one from Chrome:

image

The behavior will essentially change from being a free-form text field, to established input fields that act as a mask for entering time values.

Acceptance Criteria

Relevant Info

Which Component

input-time-picker

Example Use Case
@AdelheidF AdelheidF added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 3, 2021
@AdelheidF AdelheidF mentioned this issue Aug 3, 2021
Closed
2 tasks
@benelan benelan added this to the Freezer milestone Sep 9, 2021
@benelan benelan added deep freeze and removed needs triage Planning workflow - pending design/dev review. labels Sep 9, 2021
@eriklharper eriklharper changed the title Enhancement: Create calcite-input-time component Enhancement: Create calcite-input-time component Nov 8, 2021
@eriklharper eriklharper mentioned this issue Nov 10, 2021
Merged
@jcfranco
Copy link
Member

Linking to discussion: https://github.com/Esri/calcite-components/discussions/4360

@benelan benelan mentioned this issue May 10, 2022
Open
@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Jun 29, 2022
@eriklharper eriklharper added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. deep freeze labels Jul 18, 2022
@eriklharper eriklharper self-assigned this Jul 18, 2022
@BlakeStearman
Copy link
Member

The home app team is also interested in this enhancement. We're currently using input-time-picker in our UI for scheduling tasks where a start or end time is needed when rebuilding hosted scene layers on a schedule, and had also run into the behaviors that #2331 and #2329 cover. Notebook task scheduling is still using a very old Dojo time input, so we are looking to move to input-time-picker presently as well.

@eriklharper
Copy link
Contributor

The home app team is also interested in this enhancement. We're currently using input-time-picker in our UI for scheduling tasks where a start or end time is needed when rebuilding hosted scene layers on a schedule, and had also run into the behaviors that #2331 and #2329 cover. Notebook task scheduling is still using a very old Dojo time input, so we are looking to move to input-time-picker presently as well.

Great to hear, I am currently working on this component!

@eriklharper eriklharper mentioned this issue Aug 16, 2022
Closed
9 tasks
@eriklharper eriklharper mentioned this issue Oct 25, 2022
Closed
@geospatialem geospatialem removed the design Issues that need design consultation prior to development. label Oct 28, 2022
@geospatialem geospatialem mentioned this issue Oct 28, 2022
Closed
5 tasks
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 20, 2022
@geospatialem
Copy link
Member

Will be adding millisecond support to input-time-picker, this new component will leverage when it lands. As a result this issue is blocked by millisecond effort in #6591.

Targeting the effort for later this year in December.

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Jul 31, 2023
@eriklharper
Copy link
Contributor

eriklharper commented Sep 5, 2023 •
edited
Loading

Related issue that can be addressed by a masked input: #6898

@eriklharper eriklharper removed the blocked This issue is blocked by another issue. label Nov 27, 2023
@brittneytewks brittneytewks added the estimate - 8 Requires input from team, consider smaller steps. label Jan 29, 2024
@jcfranco jcfranco added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 22, 2024
@jcfranco jcfranco removed this from the 2024-05-28 - May Main Release milestone Apr 22, 2024
@geospatialem geospatialem mentioned this issue Apr 30, 2024
Closed
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels Sep 6, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2024
@geospatialem geospatialem changed the title Enhancement: Create calcite-input-time component Enhancement: Add input masking to input-time-picker Sep 10, 2024
@geospatialem
Copy link
Member

@AdelheidF We've updated the above scope to accommodate the current input-time-picker component through masking as an enhancement.

Based on the above workflow, we may seek consistency with input-date-picker once a pattern is established. cc @eriklharper @jcfranco

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. and removed new component Issues tied to a new component. labels Sep 10, 2024
@geospatialem geospatialem mentioned this issue Dec 18, 2024
Open
6 tasks
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriklharper eriklharper

Labels
2 - in development Issues that are actively being worked on. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
10 participants
@jcfranco @eriklharper @alisonailea @macandcheese @geospatialem @BlakeStearman @benelan @AdelheidF @ashetland @brittneytewks