Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Picker: reduce column inline padding #7416

Open
2 of 3 tasks
ashetland opened this issue Aug 1, 2023 · 2 comments
Open
2 of 3 tasks

Time Picker: reduce column inline padding #7416

ashetland opened this issue Aug 1, 2023 · 2 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Milestone
2025-06-24 - Jun ...

Comments

@ashetland
Copy link
Contributor

ashetland commented Aug 1, 2023 •
edited
Loading

Check existing issues

Description

Reduce the inline padding of each column in Time Picker to better align with Calcite norms and remove extra whitespace between inputs.

Acceptance Criteria

Inline padding on each column reduced to:

  • 0.5rem at small scale
  • 0.75rem at medium scale
  • 1.0rem at large scale

Relevant Info

A comparison of current and reduced padding can be seen in this Figma file. This proposal came up in a discussion with @eriklharper regarding his work on issue #6591. This reduced padding becomes more apparent when the decimals column is added.

Which Component

Time Picker

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 1, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 1, 2023
@ashetland ashetland added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Aug 1, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Aug 1, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@geospatialem geospatialem added low risk Issues with low risk for consideration in low risk milestones and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Nov 22, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@brittneytewks
Copy link

Removed Figma changes label as this will be tracked in monday.com

@ashetland ashetland added the p - low Issue is non core or affecting less that 10% of people using the library label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2025-06-24 - Jun Milestone
Development

No branches or pull requests
3 participants
@geospatialem @ashetland @brittneytewks