-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin event notification subscription wildcard support #6347
Plugin event notification subscription wildcard support #6347
Conversation
@rustyrussell It throws error
|
Hmm, that will happen if you're not running the modified pyln-client? Make sure you're running under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now working as expected. Good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend switching the wildcard from an empty string to [""] format. This format aligns with common practice of using "" as a wildcard symbol and array will be helpful in future with selective subscriptions.
I have switched to |
Requested-by: Shahana Farooqui @shahana Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Plugins: plugins can subscribe to all notifications using "*".
b9f6dfe
to
3bfbbf2
Compare
Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
We fixed the others. There are no fields, but this keeps it consistent. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: JSON-RPC: `shutdown` notification contains `shutdown` object (notification consistency)
3bfbbf2
to
c76b9d9
Compare
Fixed up now notifications are object-wrapped in master. |
Ack c76b9d9 |
Subscribing to "" will now give you every event: I've added support to pyln-client and libplugin for this.
Note: you can tell which notification it was in Python by having an argument called "request" and looking at "request.method"
Suggested-by: @ShahanaFarooqui