Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Notifications Usability #6340

Closed
ShahanaFarooqui opened this issue Jun 16, 2023 · 2 comments
Closed

Increase Notifications Usability #6340

ShahanaFarooqui opened this issue Jun 16, 2023 · 2 comments
Assignees
@rustyrussell
Milestone
v23.08

Comments

@ShahanaFarooqui
Copy link
Collaborator

ShahanaFarooqui commented Jun 16, 2023 •
edited
Loading

@rustyrussell

  • Add method parameter to notifications in pyln-client plugin.py: Send the method/event name back in the notification.

  • Add method to subscribed to all notifications: Add a method for subscribing to the requested list of notifications (empty string/"all"/["connect", "disconnect"] etc.)

  • Standardise all notifications response: All notifications send the response with event key except connect, disconnect, block_added and shutdown. Unify these 4 events also to send the response with corresponding event keys.
@ShahanaFarooqui
Copy link
Collaborator Author

Created a WIP PR #6345 to address Standardise all notifications response requirement.

@ShahanaFarooqui ShahanaFarooqui mentioned this issue Jun 19, 2023
Merged
@ShahanaFarooqui ShahanaFarooqui added this to the v23.08 milestone Oct 30, 2023
@ShahanaFarooqui
Copy link
Collaborator Author

Closed with PR #6388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
None yet
Projects
None yet
Milestone
v23.08
Development

No branches or pull requests
2 participants
@rustyrussell @ShahanaFarooqui