Notifications serialise connect, disconnect, block_added #6345
Conversation
| @@ -87,9 +87,11 @@ A notification for topic `connect` is sent every time a new connection to a peer | |||
|
|
|||
| ```json | |||
| { | |||
There was a problem hiding this comment.
We should talk about the form of all these notifications (i.e. that notification X will contain an object X) in the general section of this doc.
Should we remove PLUGINS.md too, as a previous commit? It's confusing to have both!
There was a problem hiding this comment.
Agree, it is redundant but we can leave it till I am not working on documentation consolidation. I will work on the logical placement of all these documents at that point anyways.
There was a problem hiding this comment.
Changelog-Added: Plugins: connect, disconnect, block_added notifications now have fields in sub-object of same name (e.g. "connect": {...}), making all notifications uniform
Changelog-Deprecated: Plugins: connect, disconnect, block_added notifications fields outside the sub-object of the same name: e.g. parse .connect.id instead of .id.
ShahanaFarooqui
changed the title
tests: notification response fixes
connect,discnnectandblock_added.Changelog-Added: Plugins: connect, disconnect, block_added notifications now have fields in sub-object of same name (e.g. "connect": {...}), making all notifications uniform
Changelog-Deprecated: Plugins: connect, disconnect, block_added notifications fields outside the sub-object of the same name: e.g. parse .connect.id instead of .id.