Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 #221 Add B3 propagator #242

Merged
merged 2 commits into from
May 6, 2024
Merged

🔧 #221 Add B3 propagator #242

merged 2 commits into from
May 6, 2024

Conversation

gernest
Copy link
Collaborator

@gernest gernest commented May 5, 2024

Followup to #221

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.05%. Comparing base (8b420f7) to head (636606d).

❗ Current head 636606d differs from pull request most recent head de6047c. Consider uploading reports for the commit de6047c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #242   +/-   ##
========================================
  Coverage    67.04%   67.05%           
========================================
  Files           78       78           
  Lines         3602     3603    +1     
========================================
+ Hits          2415     2416    +1     
  Misses        1058     1058           
  Partials       129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gernest
Copy link
Collaborator Author

gernest commented May 5, 2024

@roma-glushko any ideas on the ci failure?

@gernest gernest requested a review from roma-glushko May 5, 2024 17:32
@roma-glushko
Copy link
Member

@gernest

any ideas on the ci failure?

yes, I do, webhook URL was not passed correctly (empty) for your PRs for some reason:

2024-05-05_23-20-19

Ignore it for now, I will be investigating why this is a case

@roma-glushko
Copy link
Member

GH actions don't share secrets with forks https://github.com/orgs/community/discussions/26163 bummer. This makes implementing notifications more challenging 😌

@roma-glushko
Copy link
Member

@gernest I have changed the trigger for that action in #244 Could you please pull that change and see if that makes any difference? 🙏

* develop:
  🐛 Running the notification action from the base repo context to share secrets in a secure way (EinStack#244)
@gernest
Copy link
Collaborator Author

gernest commented May 5, 2024

@roma-glushko I pulled the changes PTAL

@roma-glushko roma-glushko added type:enhancement New feature or request area:telemetry Logging, metrics, traces labels May 6, 2024
Copy link
Member

@roma-glushko roma-glushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you!

@roma-glushko roma-glushko changed the title add b3 propagator 🔧 #221 Add B3 propagator May 6, 2024
@roma-glushko roma-glushko merged commit a54eb57 into EinStack:develop May 6, 2024
6 checks passed
@gernest gernest deleted the b3 branch May 6, 2024 15:52
roma-glushko added a commit that referenced this pull request Jun 24, 2024
The first major update with breaking changes to the language chat schemas 
and begging of work on instrumenting the gateway with OpenTelemetry.

### Added

- 🔧 Use github.com/EinStack/glide as module name to support go install cmd (@gernest)
- ✨🔧 Setup Open Telemetry Metrics and Traces (#237) (@gernest)
-  🔧 #221 Add B3 trace propagator (#242) (@gernest)
- 🔧 #241 Support overriding OTEL resource attributes (#243) (@gernest)
- 🔧 #248 Disable span and metrics by default (#254) (@gernest)
- 🔧 #220 Instrument API server with observability signals (#255) (@gernest)
- 🔧 #164 Make client connection pool configurable across all providers (#251) (@daesu)
- 🔧 Instrument gateway process (#256) (@gernest)
- 🔧 #262: adding connection pool for chat request and response (#271) (@tom-fitz)

### Changed

- 🔧 #238 Implements human-readable durations in config (#253) (@ppmdo)
- 🔧 #266: removing omitempty from response definition (#267) (@tom-fitz)

#### Breaking Changes

- 🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (#236) (@roma-glushko)
- 💥 Convert all camelCase config fields to the snake_case in the provider configs (#260) (@roma-glushko)
- ✨💥 #153: Allow to pass multiple model-specific param overrides (#264) (@roma-glushko)

### Fixed

- 🐛 #217: Set build info correctly in Glide images (#218) (@roma-glushko)

### Security

- 🔒 Updated golang to 1.22.4 to address CVE-2024-24790 (#276) (@STAR-173)

### Miscellaneous

- 📝 Defined a way to manage EinStack Glide project (#234) (@roma-glushko)
- 👷 #219: Setup local telemetry stack with Jaeger, Grafana, VictoriaMetrics and OTEL Collector (#225) (@roma-glushko)
- 👷‍♂️ Added a new GH action to watch for glide activity stream (#239, #244) (@roma-glushko)
- ✨ Switched to the new docs (@roma-glushko)
- 🔧 #240: Automatically install air (#277, #270) (@ppmdo, @roma-glushko)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:telemetry Logging, metrics, traces type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants