-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 [Telemetry] Setup OTEL Tracer(s) and Meter(s) #221
Labels
Milestone
Comments
roma-glushko
added
area:service
area:telemetry
Logging, metrics, traces
size:small
labels
Apr 27, 2024
cc @gernest this issue seems like a natural first step for the OTEL integration |
gernest
added a commit
to gernest/glide
that referenced
this issue
May 5, 2024
Closes EinStack#221 We use `go.opentelemetry.io/contrib/exporters/autoexport`` for standard loading exporter configurations via env variables. This commit, initialize metrics meter and tracer. There is no need to pass the providers in `*telemetry.Telemetry` because they are globally available via `otel` package. Only setup is implemented here to simplify review. Instrumentation will be done in followup patches.
gernest
added a commit
to gernest/glide
that referenced
this issue
May 5, 2024
Followup to EinStack#221
roma-glushko
pushed a commit
that referenced
this issue
May 6, 2024
Merged
roma-glushko
added a commit
that referenced
this issue
Jun 24, 2024
The first major update with breaking changes to the language chat schemas and begging of work on instrumenting the gateway with OpenTelemetry. ### Added - 🔧 Use github.com/EinStack/glide as module name to support go install cmd (@gernest) - ✨🔧 Setup Open Telemetry Metrics and Traces (#237) (@gernest) - 🔧 #221 Add B3 trace propagator (#242) (@gernest) - 🔧 #241 Support overriding OTEL resource attributes (#243) (@gernest) - 🔧 #248 Disable span and metrics by default (#254) (@gernest) - 🔧 #220 Instrument API server with observability signals (#255) (@gernest) - 🔧 #164 Make client connection pool configurable across all providers (#251) (@daesu) - 🔧 Instrument gateway process (#256) (@gernest) - 🔧 #262: adding connection pool for chat request and response (#271) (@tom-fitz) ### Changed - 🔧 #238 Implements human-readable durations in config (#253) (@ppmdo) - 🔧 #266: removing omitempty from response definition (#267) (@tom-fitz) #### Breaking Changes - 🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (#236) (@roma-glushko) - 💥 Convert all camelCase config fields to the snake_case in the provider configs (#260) (@roma-glushko) - ✨💥 #153: Allow to pass multiple model-specific param overrides (#264) (@roma-glushko) ### Fixed - 🐛 #217: Set build info correctly in Glide images (#218) (@roma-glushko) ### Security - 🔒 Updated golang to 1.22.4 to address CVE-2024-24790 (#276) (@STAR-173) ### Miscellaneous - 📝 Defined a way to manage EinStack Glide project (#234) (@roma-glushko) - 👷 #219: Setup local telemetry stack with Jaeger, Grafana, VictoriaMetrics and OTEL Collector (#225) (@roma-glushko) - 👷♂️ Added a new GH action to watch for glide activity stream (#239, #244) (@roma-glushko) - ✨ Switched to the new docs (@roma-glushko) - 🔧 #240: Automatically install air (#277, #270) (@ppmdo, @roma-glushko)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add new properties to the telemetry section of the Glide config to allow to setup OTEL:
Tracing
This is typically about being able to setup propagators and exporters. We should support OTEL & B3 trace content propagation protocols.
Metrics
We should have metric level config that would allow to disable metrics or enable them.
Resource attributes
It should be possible to override Glide resource attributes:
Glide should fill the required fields like service name, version, instanceID automatically if they are not overriden via the config.
Use OTEL Collector as a source of inspiration.
The text was updated successfully, but these errors were encountered: