Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 [Telemetry] Span & metrics exporting should be disabled by default #248

Closed
roma-glushko opened this issue May 6, 2024 · 6 comments · Fixed by #254
Closed

🔧 [Telemetry] Span & metrics exporting should be disabled by default #248

roma-glushko opened this issue May 6, 2024 · 6 comments · Fixed by #254
Labels
area:telemetry Logging, metrics, traces good first issue Good for newcomers size:small
Milestone
Glide: Public Pre...

Comments

@roma-glushko
Copy link
Member

Tracing and metrics should be optional and disabled by default in case people don't have a backend to export them and view:

2024-05-06_22-52-50
@roma-glushko roma-glushko added good first issue Good for newcomers area:telemetry Logging, metrics, traces size:small labels May 6, 2024
@roma-glushko roma-glushko added this to the Glide: Public Preview milestone May 6, 2024
@roma-glushko
Copy link
Member Author

cc @gernest

@gernest
Copy link
Collaborator

gernest commented May 6, 2024

Probably you have otel envs setup . Default providers are none. which is a noop provider. Looks like you have otel configured pointing to localhost:4314/v1/metrics ? the port looks like from victoria metrics or something?

You can close this, it is not a glide issue.

@gernest
Copy link
Collaborator

gernest commented May 8, 2024

@roma-glushko did you check otel env vars? Just needs to make sure this is not an issue, before I start instrumentation this weekend.

@roma-glushko
Copy link
Member Author

@gernest I don't think I have any OTEL_* env variables set. This is reproducible when I just start a dev process via make run and then execute some workflows like chat requests, then after some time I start seeing this warning.

In that workflow, I don't any environment variables other than provider's API keys.

@roma-glushko
Copy link
Member Author

Tracing and metrics should be disabled by default as they require special tools to take advantage of them and we have no assumptions/requirements around users having that in place. If I just install Glide via brew and start the process with a simple config, there should no warnings about inability to export metrics or traces and there would no additional environment variables to setup observability (unless the user goes for that after some time playing around with Glide).

@gernest
Copy link
Collaborator

gernest commented May 10, 2024

I was able to reproduce this locally, will work on a fix.

gernest added a commit to gernest/glide that referenced this issue May 10, 2024
@gernest
Disable span and metrics by default
25645f8 
fixes EinStack#248

This commit adds fallback exporters to autoexport. Ensuring spans and metrics
are disabled.

A unit test is included to ensure we use the correct exporters.
@gernest gernest mentioned this issue May 10, 2024
Merged
roma-glushko pushed a commit that referenced this issue May 12, 2024
@gernest
🔧 #248 Disable span and metrics by default (#254)
321b002
gernest added a commit to gernest/glide that referenced this issue May 15, 2024
@gernest
Merge branch 'develop' into instrument-gateway
e44df0e 
* develop:
  🔧 💥 EinStack#235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (EinStack#236)
  🔧 EinStack#220 Instrument API server (EinStack#255)
  🔧 EinStack#248 Disable span and metrics by default (EinStack#254)
@roma-glushko roma-glushko mentioned this issue Jun 24, 2024
Merged
roma-glushko added a commit that referenced this issue Jun 24, 2024
@roma-glushko
📦 Release: v0.1.0-rc.1 (#280)
1e2b16f 
The first major update with breaking changes to the language chat schemas 
and begging of work on instrumenting the gateway with OpenTelemetry.

### Added

- 🔧 Use github.com/EinStack/glide as module name to support go install cmd (@gernest)
- ✨🔧 Setup Open Telemetry Metrics and Traces (#237) (@gernest)
-  🔧 #221 Add B3 trace propagator (#242) (@gernest)
- 🔧 #241 Support overriding OTEL resource attributes (#243) (@gernest)
- 🔧 #248 Disable span and metrics by default (#254) (@gernest)
- 🔧 #220 Instrument API server with observability signals (#255) (@gernest)
- 🔧 #164 Make client connection pool configurable across all providers (#251) (@daesu)
- 🔧 Instrument gateway process (#256) (@gernest)
- 🔧 #262: adding connection pool for chat request and response (#271) (@tom-fitz)

### Changed

- 🔧 #238 Implements human-readable durations in config (#253) (@ppmdo)
- 🔧 #266: removing omitempty from response definition (#267) (@tom-fitz)

#### Breaking Changes

- 🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (#236) (@roma-glushko)
- 💥 Convert all camelCase config fields to the snake_case in the provider configs (#260) (@roma-glushko)
- ✨💥 #153: Allow to pass multiple model-specific param overrides (#264) (@roma-glushko)

### Fixed

- 🐛 #217: Set build info correctly in Glide images (#218) (@roma-glushko)

### Security

- 🔒 Updated golang to 1.22.4 to address CVE-2024-24790 (#276) (@STAR-173)

### Miscellaneous

- 📝 Defined a way to manage EinStack Glide project (#234) (@roma-glushko)
- 👷 #219: Setup local telemetry stack with Jaeger, Grafana, VictoriaMetrics and OTEL Collector (#225) (@roma-glushko)
- 👷‍♂️ Added a new GH action to watch for glide activity stream (#239, #244) (@roma-glushko)
- ✨ Switched to the new docs (@roma-glushko)
- 🔧 #240: Automatically install air (#277, #270) (@ppmdo, @roma-glushko)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:telemetry Logging, metrics, traces good first issue Good for newcomers size:small
Projects
None yet
Milestone
Glide: Public Preview
Development

Successfully merging a pull request may close this issue.

🔧 #248 Disable span and metrics by default gernest/glide
2 participants
@gernest @roma-glushko