Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close db when insert finished #714

Merged
merged 2 commits into from
Sep 22, 2023
Merged

close db when insert finished #714

merged 2 commits into from
Sep 22, 2023

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Sep 19, 2023

What this PR does / why we need it:
close db when insert finished
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #713

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:
close db when insert finished
Release note:

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.06% ⚠️

Comparison is base (5a19f6b) 55.16% compared to head (0394752) 55.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   55.16%   55.10%   -0.06%     
==========================================
  Files          23       23              
  Lines        2277     2283       +6     
==========================================
+ Hits         1256     1258       +2     
- Misses        907      911       +4     
  Partials      114      114              
Files Changed Coverage Δ
pkg/telemetryservice/sql/mysql/mysql.go 64.28% <0.00%> (-3.22%) ⬇️
pkg/telemetryservice/sql/sqlserver/sqlserver.go 63.41% <0.00%> (-3.26%) ⬇️
pkg/telemetryservice/sql/tdengine/tdengine.go 76.31% <100.00%> (+1.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leepala added 1 comment

pkg/telemetryservice/sql/mysql/mysql.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 42820bf into main Sep 22, 2023
13 of 15 checks passed
@tomqin93 tomqin93 deleted the close_db branch September 22, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TelemetryService suspected memory leak.
6 participants