close db when insert finished (#714)

* close db when insert finished * use defer instead of return db.close --------- Co-authored-by: 李毓琪 <[email protected]>
Edgenesis · Sep 22, 2023 · 42820bf · 42820bf
1 parent 5a19f6b
commit 42820bf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/pkg/telemetryservice/sql/mysql/mysql.go b/pkg/telemetryservice/sql/mysql/mysql.go
@@ -35,6 +35,8 @@ func (db *DBHelper) SendToDB(ctx context.Context, deviceName string, rawData []b
 		return err
 	}
 
+	defer db.DB.Close()
+
 	err = db.InsertDataToDB(ctx, deviceName, rawData)
 	if err != nil {
 		logger.Errorf("Error to Insert rawData to DB, errror: %v", err.Error())

diff --git a/pkg/telemetryservice/sql/sqlserver/sqlserver.go b/pkg/telemetryservice/sql/sqlserver/sqlserver.go
@@ -35,6 +35,8 @@ func (db *DBHelper) SendToDB(ctx context.Context, deviceName string, rawData []b
 		return err
 	}
 
+	defer db.DB.Close()
+
 	err = db.InsertDataToDB(ctx, deviceName, rawData)
 	if err != nil {
 		logger.Errorf("Error to Insert rawData to DB, errror: %v", err.Error())

diff --git a/pkg/telemetryservice/sql/tdengine/tdengine.go b/pkg/telemetryservice/sql/tdengine/tdengine.go
@@ -28,6 +28,8 @@ func (db *DBHelper) SendToDB(ctx context.Context, deviceName string, rawData []b
 		return err
 	}
 
+	defer db.DB.Close()
+
 	err = db.InsertDataToDB(ctx, deviceName, rawData)
 	if err != nil {
 		logger.Errorf("Error to Insert rawData to DB, errror: %v", err.Error())