Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close db when insert finished #714

Merged
merged 2 commits into from
Sep 22, 2023
Merged

close db when insert finished #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db2b1c2
close db when insert finished
Sep 19, 2023
0394752
use defer instead of return db.close
Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/telemetryservice/sql/mysql/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
return err
}

defer db.DB.Close()

Check warning on line 39 in pkg/telemetryservice/sql/mysql/mysql.go

View check run for this annotation

Codecov / codecov/patch

pkg/telemetryservice/sql/mysql/mysql.go#L38-L39 

Added lines #L38 - L39 were not covered by tests
err = db.InsertDataToDB(ctx, deviceName, rawData)
if err != nil {
logger.Errorf("Error to Insert rawData to DB, errror: %v", err.Error())
Expand Down
2 changes: 2 additions & 0 deletions pkg/telemetryservice/sql/sqlserver/sqlserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
return err
}

defer db.DB.Close()

Check warning on line 39 in pkg/telemetryservice/sql/sqlserver/sqlserver.go

View check run for this annotation

Codecov / codecov/patch

pkg/telemetryservice/sql/sqlserver/sqlserver.go#L38-L39 

Added lines #L38 - L39 were not covered by tests
err = db.InsertDataToDB(ctx, deviceName, rawData)
if err != nil {
logger.Errorf("Error to Insert rawData to DB, errror: %v", err.Error())
Expand Down
2 changes: 2 additions & 0 deletions pkg/telemetryservice/sql/tdengine/tdengine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ func (db *DBHelper) SendToDB(ctx context.Context, deviceName string, rawData []b
return err
}

defer db.DB.Close()

err = db.InsertDataToDB(ctx, deviceName, rawData)
if err != nil {
logger.Errorf("Error to Insert rawData to DB, errror: %v", err.Error())
Expand Down
Loading