Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio) - Fix rounding errors in ADC value calculation for 6POS switch. #3713

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jun 23, 2023

Fixes #3711

Tested in simulator and on TX16S Mk2.

@pfeerick
Copy link
Member

Good on Boxer also

@pfeerick pfeerick added the bug 🪲 Something isn't working label Jun 23, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jun 23, 2023
@pfeerick pfeerick changed the base branch from main to 2.9 June 24, 2023 08:40
@pfeerick pfeerick merged commit 5ebd090 into EdgeTX:2.9 Jun 25, 2023
pfeerick added a commit that referenced this pull request Jun 26, 2023
commit 865d34a
Author: 3djc <[email protected]>
Date:   Sat Jun 24 11:11:43 2023 +0200

    'oh boy' fix

commit c15cbf3
Author: 3djc <[email protected]>
Date:   Thu Jun 22 10:00:34 2023 +0200

    yaml update

commit a31e1e9
Author: 3djc <[email protected]>
Date:   Thu Jun 22 08:52:45 2023 +0200

    reuse !

commit d28be2d
Author: 3djc <[email protected]>
Date:   Thu Jun 22 08:39:32 2023 +0200

    yaml update

commit 7482fee
Author: 3djc <[email protected]>
Date:   Wed Jun 21 14:30:14 2023 +0200

    Fix possible muted on boot scenario

commit e51f686
Author: 3djc <[email protected]>
Date:   Wed Jun 21 12:27:37 2023 +0200

    compil fixes

commit fbde97f
Author: 3djc <[email protected]>
Date:   Wed Jun 21 12:18:11 2023 +0200

    Some compile fixes

commit fe08f71
Author: 3djc <[email protected]>
Date:   Wed Jun 21 11:12:19 2023 +0200

    User configurable audio mute

commit 5268ba0
Author: Peter Feerick <[email protected]>
Date:   Sun Jun 25 20:37:41 2023 +1000

    chore: GH should be building 2.9 branch

commit 0f0e71e
Author: Peter Feerick <[email protected]>
Date:   Sun Jun 25 20:02:14 2023 +1000

    chore: Add codename

commit 5ebd090
Author: philmoz <[email protected]>
Date:   Sun Jun 25 15:09:46 2023 +1000

    fix: Rounding errors in ADC value calculation for 6POS switch (#3713)

commit 3ea236e
Author: Peter Feerick <[email protected]>
Date:   Fri Jun 23 18:46:06 2023 +1000

    fix(sim): do not allow launching if no radio profiles found (#3712)

    * Test for existence of radio profiles and advise if not found

    * Fix message box title and move simulator name to constants

commit 41467e3
Author: Michael <[email protected]>
Date:   Fri Jun 23 05:52:54 2023 +0200

    chore: Remove rssiSource and use default value (#3643)

    * fixes #2552

    - remove edit option rssiSource
    - reset rssiOption to default (none) if carried over from OpenTX conversion

    * deleted rssiSource functional code Companion, simulator and radio

    * forgot one commented line

commit 7b509a7
Author: philmoz <[email protected]>
Date:   Fri Jun 23 10:37:12 2023 +1000

    fix(cpn): Wrong input offset value saved to YAML if GV (#3707)

commit cee7393
Author: Neil Horne <[email protected]>
Date:   Fri Jun 23 09:07:55 2023 +1000

    feat(cpn): Add radio sort order edit and sorting models list by any column (#3659)

    * feat(cpn): Add radio sort order edit (color) and sorting models list by any column (all)

    * Add column double click to enable/disable model sorting (disabled by default)

commit 470db43
Author: Michael <[email protected]>
Date:   Thu Jun 22 12:34:09 2023 +0200

    fix(color): Firmware update progress text stuck at device reset (#3704)

    * fixes #3695 flash progress

    * move init() to where it belongs (constructor)

commit 302bf3e
Author: richardclli <[email protected]>
Date:   Thu Jun 22 13:14:12 2023 +0800

    fix: 3POS switches on certain radios not detecting all switch positions (#3568)

    * Quick and dirty fix for #3560.

    * Fixed build error.

    * Fixed problematic logic.

    * Code cleanup.

commit a1528db
Author: richardclli <[email protected]>
Date:   Wed Jun 21 18:56:55 2023 +0800

    chore: Add EL18 specific build for v2.9 (#3539)

    * chore: Add EL18 specific firmware naming (#2609)

    * Added EL18 specific firmware naming.

    * fix: Update USB identifier

    * chore: Add to github builds

    * fix: Lowercase s in Flysky

    * chore: Reference EL18 specific firmware file

    Co-authored-by: Peter Feerick <[email protected]>

    * chore(el18): Change default switch cfg to match production (#2675)

    * chore: no nightly build for this branch

commit 72c733c
Author: 3djc <[email protected]>
Date:   Tue Jun 20 11:32:12 2023 +0200

    fix: (re)enable time based mute for TX16S based on RM feedback (#3701)
@philmoz philmoz deleted the fix-6pos-calc branch October 23, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect display of six position switch operation
2 participants