fix: 3POS switches on certain radios not detecting all switch positions #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested in EL18, it works properly. |
|
This will most likely be another PR that gets merged only after 2.9 branch-off |
|
Tested on RM TX16S / Zorro, iFlight Commando8, Jumper TPro, Frsky X9D+, Flysky NV14 / EL18 (with misconfigured 3POS switches) and all were detecting switch position and triggering SF just fine. |
pfeerick
changed the title
pfeerick
added a commit
that referenced
this pull request
Jun 26, 2023
commit 865d34a Author: 3djc <[email protected]> Date: Sat Jun 24 11:11:43 2023 +0200 'oh boy' fix commit c15cbf3 Author: 3djc <[email protected]> Date: Thu Jun 22 10:00:34 2023 +0200 yaml update commit a31e1e9 Author: 3djc <[email protected]> Date: Thu Jun 22 08:52:45 2023 +0200 reuse ! commit d28be2d Author: 3djc <[email protected]> Date: Thu Jun 22 08:39:32 2023 +0200 yaml update commit 7482fee Author: 3djc <[email protected]> Date: Wed Jun 21 14:30:14 2023 +0200 Fix possible muted on boot scenario commit e51f686 Author: 3djc <[email protected]> Date: Wed Jun 21 12:27:37 2023 +0200 compil fixes commit fbde97f Author: 3djc <[email protected]> Date: Wed Jun 21 12:18:11 2023 +0200 Some compile fixes commit fe08f71 Author: 3djc <[email protected]> Date: Wed Jun 21 11:12:19 2023 +0200 User configurable audio mute commit 5268ba0 Author: Peter Feerick <[email protected]> Date: Sun Jun 25 20:37:41 2023 +1000 chore: GH should be building 2.9 branch commit 0f0e71e Author: Peter Feerick <[email protected]> Date: Sun Jun 25 20:02:14 2023 +1000 chore: Add codename commit 5ebd090 Author: philmoz <[email protected]> Date: Sun Jun 25 15:09:46 2023 +1000 fix: Rounding errors in ADC value calculation for 6POS switch (#3713) commit 3ea236e Author: Peter Feerick <[email protected]> Date: Fri Jun 23 18:46:06 2023 +1000 fix(sim): do not allow launching if no radio profiles found (#3712) * Test for existence of radio profiles and advise if not found * Fix message box title and move simulator name to constants commit 41467e3 Author: Michael <[email protected]> Date: Fri Jun 23 05:52:54 2023 +0200 chore: Remove rssiSource and use default value (#3643) * fixes #2552 - remove edit option rssiSource - reset rssiOption to default (none) if carried over from OpenTX conversion * deleted rssiSource functional code Companion, simulator and radio * forgot one commented line commit 7b509a7 Author: philmoz <[email protected]> Date: Fri Jun 23 10:37:12 2023 +1000 fix(cpn): Wrong input offset value saved to YAML if GV (#3707) commit cee7393 Author: Neil Horne <[email protected]> Date: Fri Jun 23 09:07:55 2023 +1000 feat(cpn): Add radio sort order edit and sorting models list by any column (#3659) * feat(cpn): Add radio sort order edit (color) and sorting models list by any column (all) * Add column double click to enable/disable model sorting (disabled by default) commit 470db43 Author: Michael <[email protected]> Date: Thu Jun 22 12:34:09 2023 +0200 fix(color): Firmware update progress text stuck at device reset (#3704) * fixes #3695 flash progress * move init() to where it belongs (constructor) commit 302bf3e Author: richardclli <[email protected]> Date: Thu Jun 22 13:14:12 2023 +0800 fix: 3POS switches on certain radios not detecting all switch positions (#3568) * Quick and dirty fix for #3560. * Fixed build error. * Fixed problematic logic. * Code cleanup. commit a1528db Author: richardclli <[email protected]> Date: Wed Jun 21 18:56:55 2023 +0800 chore: Add EL18 specific build for v2.9 (#3539) * chore: Add EL18 specific firmware naming (#2609) * Added EL18 specific firmware naming. * fix: Update USB identifier * chore: Add to github builds * fix: Lowercase s in Flysky * chore: Reference EL18 specific firmware file Co-authored-by: Peter Feerick <[email protected]> * chore(el18): Change default switch cfg to match production (#2675) * chore: no nightly build for this branch commit 72c733c Author: 3djc <[email protected]> Date: Tue Jun 20 11:32:12 2023 +0200 fix: (re)enable time based mute for TX16S based on RM feedback (#3701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3560
The ultimate fix is #2631 in milestone 2.10.0