Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.9 - When writing the firmware on external module sentence is wrong #3695

Closed
1 task done
robustini opened this issue Jun 18, 2023 · 2 comments · Fixed by #3704
Closed
1 task done

2.9 - When writing the firmware on external module sentence is wrong #3695

robustini opened this issue Jun 18, 2023 · 2 comments · Fixed by #3704
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios

Comments

@robustini
Copy link
Contributor

robustini commented Jun 18, 2023 •
edited
Loading

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I just noticed today that when I write the firmware of the FrSky R9M module with ELRS during the flash at the bottom the words "module reset" remains even while writing as seen in the image, when it should only appear initially and then write "writing in progress".

Expected Behavior

It should do what I wrote above, I tried it with an older EdgeTX firmware (2.8) and in fact it works.
I don't think the problem is in the language, IT is correct, here the two different sentences, the second one should appear while writing:

#define TR_DEVICE_RESET "Resetto dispositivo..."
#define TR_WRITING "Scrittura..."

Steps To Reproduce

  1. Flash the latest master (2.9)
  2. Write ELRS firmware to external module

Version

Nightly (Please give date/commit below)

Transmitter

FrSky X10 Express / X10S Express (ACCESS)

Operating System (OS)

Windows

OS Version

Windows 10 Pro x64

Anything else?

immagine
@robustini robustini added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jun 18, 2023
@robustini robustini changed the title 2.9 - When writing the ELRS firmware on TX the sentence is wrong 2.9 - When writing the ELRS firmware on TX external module the sentence is wrong Jun 18, 2023
@pfeerick pfeerick changed the title 2.9 - When writing the ELRS firmware on TX external module the sentence is wrong 2.9 - When writing the firmware on external module sentence is wrong Jun 19, 2023
@pfeerick
Copy link
Member

pfeerick commented Jun 19, 2023 •
edited
Loading

It's not unique to ELRS... it's the same for all. We'd noticed it before, but I didn't realise it was correct in 2.8, so will see what changed there - thanks for pointing that out! :)

It's been this way since around #3055 (or perhaps earlier - I just remember first seeing it around then). The STR_FLASH_DEVICE heading and STR_DEVICE_RESET is also delayed, probably until after the reset, so something else is going on there. This can also be seen on the simulator, there is mock code to allow that to behave the same as a real on-radio firmware update.

@philmoz Is this something you can look at? - I'm thinking it's mainly a GUI issue and is at least reproducible in simulator... it really should show the heading and "device reset" text first (while resetting), and then switch to "writing" once writing commences...

@pfeerick pfeerick added color Related generally to color LCD radios bug/regression ↩️ A new version of EdgeTX broke something and removed bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jun 19, 2023
@robustini
Copy link
Contributor Author

@pfeerick thanks Peter for your feedback.
In the TX16S I have firmware compiled in November 2022, actually quite dated, and it works there.

mha1 added a commit to mha1/edgetx that referenced this issue Jun 21, 2023
@mha1
fixes EdgeTX#3695 flash progress
14a9cd9
@mha1 mha1 mentioned this issue Jun 21, 2023
Merged
pfeerick pushed a commit that referenced this issue Jun 22, 2023
@mha1
fix(color): Firmware update progress text stuck at device reset (#3704)
d579619 
* fixes #3695 flash progress

* move init() to where it belongs (constructor)
pfeerick pushed a commit that referenced this issue Jun 23, 2023
@mha1 @pfeerick
fix(color): Firmware update progress text stuck at device reset (#3704)
470db43 
* fixes #3695 flash progress

* move init() to where it belongs (constructor)
pfeerick added a commit that referenced this issue Jun 26, 2023
@pfeerick
Squashed commit of most of a698ab1
667b52d 
commit 865d34a
Author: 3djc <[email protected]>
Date:   Sat Jun 24 11:11:43 2023 +0200

    'oh boy' fix

commit c15cbf3
Author: 3djc <[email protected]>
Date:   Thu Jun 22 10:00:34 2023 +0200

    yaml update

commit a31e1e9
Author: 3djc <[email protected]>
Date:   Thu Jun 22 08:52:45 2023 +0200

    reuse !

commit d28be2d
Author: 3djc <[email protected]>
Date:   Thu Jun 22 08:39:32 2023 +0200

    yaml update

commit 7482fee
Author: 3djc <[email protected]>
Date:   Wed Jun 21 14:30:14 2023 +0200

    Fix possible muted on boot scenario

commit e51f686
Author: 3djc <[email protected]>
Date:   Wed Jun 21 12:27:37 2023 +0200

    compil fixes

commit fbde97f
Author: 3djc <[email protected]>
Date:   Wed Jun 21 12:18:11 2023 +0200

    Some compile fixes

commit fe08f71
Author: 3djc <[email protected]>
Date:   Wed Jun 21 11:12:19 2023 +0200

    User configurable audio mute

commit 5268ba0
Author: Peter Feerick <[email protected]>
Date:   Sun Jun 25 20:37:41 2023 +1000

    chore: GH should be building 2.9 branch

commit 0f0e71e
Author: Peter Feerick <[email protected]>
Date:   Sun Jun 25 20:02:14 2023 +1000

    chore: Add codename

commit 5ebd090
Author: philmoz <[email protected]>
Date:   Sun Jun 25 15:09:46 2023 +1000

    fix: Rounding errors in ADC value calculation for 6POS switch (#3713)

commit 3ea236e
Author: Peter Feerick <[email protected]>
Date:   Fri Jun 23 18:46:06 2023 +1000

    fix(sim): do not allow launching if no radio profiles found (#3712)

    * Test for existence of radio profiles and advise if not found

    * Fix message box title and move simulator name to constants

commit 41467e3
Author: Michael <[email protected]>
Date:   Fri Jun 23 05:52:54 2023 +0200

    chore: Remove rssiSource and use default value (#3643)

    * fixes #2552

    - remove edit option rssiSource
    - reset rssiOption to default (none) if carried over from OpenTX conversion

    * deleted rssiSource functional code Companion, simulator and radio

    * forgot one commented line

commit 7b509a7
Author: philmoz <[email protected]>
Date:   Fri Jun 23 10:37:12 2023 +1000

    fix(cpn): Wrong input offset value saved to YAML if GV (#3707)

commit cee7393
Author: Neil Horne <[email protected]>
Date:   Fri Jun 23 09:07:55 2023 +1000

    feat(cpn): Add radio sort order edit and sorting models list by any column (#3659)

    * feat(cpn): Add radio sort order edit (color) and sorting models list by any column (all)

    * Add column double click to enable/disable model sorting (disabled by default)

commit 470db43
Author: Michael <[email protected]>
Date:   Thu Jun 22 12:34:09 2023 +0200

    fix(color): Firmware update progress text stuck at device reset (#3704)

    * fixes #3695 flash progress

    * move init() to where it belongs (constructor)

commit 302bf3e
Author: richardclli <[email protected]>
Date:   Thu Jun 22 13:14:12 2023 +0800

    fix: 3POS switches on certain radios not detecting all switch positions (#3568)

    * Quick and dirty fix for #3560.

    * Fixed build error.

    * Fixed problematic logic.

    * Code cleanup.

commit a1528db
Author: richardclli <[email protected]>
Date:   Wed Jun 21 18:56:55 2023 +0800

    chore: Add EL18 specific build for v2.9 (#3539)

    * chore: Add EL18 specific firmware naming (#2609)

    * Added EL18 specific firmware naming.

    * fix: Update USB identifier

    * chore: Add to github builds

    * fix: Lowercase s in Flysky

    * chore: Reference EL18 specific firmware file

    Co-authored-by: Peter Feerick <[email protected]>

    * chore(el18): Change default switch cfg to match production (#2675)

    * chore: no nightly build for this branch

commit 72c733c
Author: 3djc <[email protected]>
Date:   Tue Jun 20 11:32:12 2023 +0200

    fix: (re)enable time based mute for TX16S based on RM feedback (#3701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flash progress text stuck at device reset mha1/edgetx
2 participants
@robustini @pfeerick