-
-
Notifications
You must be signed in to change notification settings - Fork 62.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Use Kramdown processor #6677
fix(docs): Use Kramdown processor #6677
Conversation
Initial addressed at commit 83b7ee4
NOTESApply this PR first than #6625 to resolve conflicts there. ABOUT HELP WANTED...To compare results between We need mount versioned environments using different config parameters:
For more info see docs at: |
Thanks! Removing the trailing spaces was actually required for the parsing, otherwise it wouldn't render right |
This comment has been minimized.
This comment has been minimized.
Typo here, you probably meant GFM. We don't need to try the first two options -
This is what the main repo has today, which works except for the issues with rendering anchors that have special characters (#6508)
This is the option in this PR/branch, I've added it back in to make it explicit but it doesn't need to be there. This works for both the RTL text parsing and the anchor rendering, but requires that plain URLs be marked up too, i.e., written as So we only need to test these two:
Not sure what the goal is here, you'd like to test them so that we can avoid having to change the URLs? What should be tested when changing the different processor configurations? |
specifying `markdown: kramdown` explicitly did not change url parsing behavior
I tested these two other configurations:
|
Here are some other discussions about linking: |
Previewing I realize now that #6662 is broken. To solve, it needs add free-programming-books/README.md Lines 6 to 11 in 7fdc28d
|
What does this PR do?
Related to PR #5810. Fixes #6508.
Using GFM causes issues with anchor tags, using Kramdown would solve the issues with anchor tags, but results in issues with links, see discussion in kramdown/parser-gfm#28. So the link was manually added, i.e., using
[url](url)
instead of justurl
.Checklist:
Follow-up