-
-
Notifications
You must be signed in to change notification settings - Fork 62.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Update markdown processor to use GFM #5810
Merged
eshellman
merged 2 commits into
EbookFoundation:master
from
charlottetan:charlottetan-markdown-gfm
Oct 4, 2021
Merged
fix(docs): Update markdown processor to use GFM #5810
eshellman
merged 2 commits into
EbookFoundation:master
from
charlottetan:charlottetan-markdown-gfm
Oct 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Update pr title with scope ℹ️ remove non scoped tasks |
More docs about GMF & Kramdown: https://jekyllrb.com/docs/configuration/markdown/#commonmark 🆗 I have not seen any other listing break. |
davorpa
requested changes
Oct 3, 2021
davorpa
added
the
waiting for changes
PR has been reviewed and changes/suggestions requested
label
Oct 3, 2021
charlottetan
changed the title
Update markdown processor to use GFM
fix(docs): Update markdown processor to use GFM
Oct 3, 2021
davorpa
approved these changes
Oct 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge 🎆 🎉
Thanks for your valuable researches
davorpa
removed
the
waiting for changes
PR has been reviewed and changes/suggestions requested
label
Oct 3, 2021
Awesome teamwork |
This was referenced Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve repo: Update the markdown processor to use GFM instead of the default (kramdown). GFM is the processor Github uses. Resolves #5559.
Docs for more information:
https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/setting-a-markdown-processor-for-your-github-pages-site-using-jekyll
Examples here:
https://charlottetan.github.io/free-programming-books/CONTRIBUTING-fa_IR.html
https://charlottetan.github.io/free-programming-books/HOWTO-fa_IR.html
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:
Follow-up