Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Use Markdown instead HTML markup for h3 & h4 headings #6688

Closed
davorpa opened this issue Jan 30, 2022 · 0 comments · Fixed by #6689
Closed

bug: Use Markdown instead HTML markup for h3 & h4 headings #6688

davorpa opened this issue Jan 30, 2022 · 0 comments · Fixed by #6689
Assignees
@davorpa
Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages PR requested Issues that can be addressed with a new PR

Comments

@davorpa
Copy link
Member

davorpa commented Jan 30, 2022 •
edited
Loading

Switching to Kramdown (#6677) would be ideal here. #6678 would completely break the search engine and parser used in #6643.

Originally posted by @brogan20 in #6508 (comment)

There are already some HTML heading markup used to define sections / categories.

<h3 id="cpp">C++</h3>

Change it to respective Markdown markup using HTML anchors

### <a name="cpp"></a>C++

for linking in index section as:

* [C++](#cpp)

Take that as reference, so look up in code for other cases.
@davorpa davorpa changed the title bug: Avoid use HTML markup to define sections bug: Use Markdown instead HTML markup for h3 & h4 headings Jan 30, 2022
@davorpa davorpa added the PR requested Issues that can be addressed with a new PR label Jan 30, 2022
@davorpa davorpa self-assigned this Jan 30, 2022
@davorpa davorpa mentioned this issue Jan 30, 2022
Merged
3 tasks
@davorpa davorpa mentioned this issue Feb 9, 2022
Merged
2 tasks
davorpa added a commit to davorpa/free-programming-books that referenced this issue Feb 9, 2022
@davorpa
revert feature moved to EbookFoundation#6688
3c263ac
@davorpa davorpa added the 🐛 BUG Confirmed bugs, normally at GitHub Pages label Feb 11, 2022
eshellman added a commit that referenced this issue Feb 11, 2022
@davorpa @eshellman
feat: Add docs/readme.md + update crosslinks (#6700)
7a8349a 
* complete translate list with the new languages appeared since hacktoberfest

* Create docs/README.md with the translations section

using root README.md as source. Links are adapted to this folder

Address #6698

* fix remaining url + translation items

- Portuguese (Portugal)
- Slovak / slovenčina
- Slovenian / slovenščina

Address #6698

* fix remaining url + translation items

- Portuguese (Portugal)
- Slovak / slovenčina
- Slovenian / slovenščina

Address #6698

* Add inclusiveness `dare to translate...` paragraph

* Add inclusiveness `dare to translate...` paragraph

* Move translations link target url to docs

* move translation links `bs`

* move translations link `en`

* move translations crosslink `es`

* move translations crosslink `fr`

* move translations crosslink `de`

* move translations crosslink `el`

* move translations crosslink `fa_IR`

* move translations crosslink `fil`

* move translations crosslink `it`

* move translations crosslink `pt_BR`

* move translations crosslink `ko`

* move translations crosslink `ru`

* move translations crosslink `id`

* move translations crosslink `zh`

* move translations crosslink `hi`

* move translations crosslink `pl`

* move translations crosslink `uk`

* move translations crosslink `vi`

* move translations crosslink remaining `HOW-To's`

* revert feature moved to #6688

* Remove the list from the top level. Leave `en` links

* use `previous languages` in root README

* Add more languages lists in root `readme.md`

* fix typo

* fix typo

* Update docs/README.md after translations paragraph

Less text is more

Co-authored-by: Eric Hellman <[email protected]>

* Update README.md after translations paragraph 

Less text is more

Co-authored-by: Eric Hellman <[email protected]>

* Update README.md preface translations paragraph 

Co-authored-by: Eric Hellman <[email protected]>

* fix CONTRIBUTING target url commited at fd2b391

* Update docs/README.md preface translations paragraph 

Co-authored-by: Eric Hellman <[email protected]>

* read me! said the boss ^^,

less text is more.

Co-authored-by: Eric Hellman <[email protected]>

* remove "The inclusiveness is one of our targets, so "

Co-authored-by: Eric Hellman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davorpa davorpa

Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages PR requested Issues that can be addressed with a new PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use Markdown instead of HTML markup for H3 & H4 headings davorpa/free-programming-books
1 participant
@davorpa