Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait functions to PID class #33

Closed
ssejrog opened this issue Jan 1, 2022 · 1 comment
Closed

Add wait functions to PID class #33

ssejrog opened this issue Jan 1, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ssejrog
Copy link
Member

ssejrog commented Jan 1, 2022

Is your feature request related to a problem? Please describe.

The PID class was forgotten about and should be unforgotten.

Describe the solution you'd like

Add a wait, wait_until, and is_at_position(?) functions. These functions should be used in chassis.wait() and chassis.wait_until().

Additional context

Having the wait functions in the Drive class is bad. They should be in the PID class, and the necessary modifications should be made in the chassis.wait() and chassis.wait_until() functions. For example, when the left side is within small_thresh for the required amount of time, the code shouldn't exit until the right side has also completed this.

interfered (#16) should be moved to these new functions. chassis.interfered should be set when the left and right have interfered.

by defaulting the exit condition constants to 0 except for small_exit, only the small exit should run. when the other values are set to numbers that aren't 0, they should be introduced.

chassis exit conditions need to stay backwards compatible

@ssejrog ssejrog added the enhancement New feature or request label Jan 1, 2022
@ssejrog ssejrog self-assigned this Jan 1, 2022
ssejrog added a commit that referenced this issue Jan 3, 2022
@ssejrog
Copy link
Member Author

ssejrog commented Jan 3, 2022

Still needs to be incorporated to the drive, comments, and a wiki page.

ssejrog added a commit that referenced this issue Jan 6, 2022
Still needs wiki page for #33.

Fixed issue with #12
Fixed issue with #35
ssejrog added a commit that referenced this issue Jan 8, 2022
Fixed error in mA calculation #33

Authored with @HakopZ
ssejrog added a commit that referenced this issue Jan 9, 2022
Modified print function and added PID names to print (#33)

Added disable for the limit switch task if it's not initialized (#34)
@ssejrog ssejrog closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant