cam6_3_146: ZM clean up in preparation for using via CCPP and remove zmconv_microp feature #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
approved these changes
Nov 14, 2023
nusbaume
requested review from
peverwhee and
mwaxmonsky
and removed request for
peverwhee
mwaxmonsky
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Looks great! Had a few questions discussed during our weekly SIMA meeting so no need for any changes that I can see.
Thanks for tackling this one @cacraigucar!
nusbaume
requested changes
Jan 12, 2024
| @@ -155,6 +155,7 @@ subroutine zm_conv_register | |||
| ! convective mass fluxes | |||
| call pbuf_add_field('CMFMC_DP', 'physpkg', dtype_r8, (/pcols,pverp/), mconzm_idx) | |||
|
|
|||
| !CACNOTE - Is zm_org really a constituent or was it just a handy structure to use for an allocatable which persists in the run? | |||
mwaxmonsky
approved these changes
Jan 19, 2024
Merge pull request ESCOMP#938 from PUMASDevelopment/katetc/rainevap_pr
nusbaume
approved these changes
Jan 20, 2024
cacraigucar
changed the title
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
May 2, 2024
Merge pull request ESCOMP#890 from cacraigucar/cam_zm_clean_up ZM clean up in preparation for using via CCPP and remove zmconv_microp feature ESCOMP commit: 11900b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in the CCPP conversion process. It has the ZM module separated into its key components and all of the CAM "use" statements lower down have been removed and variables are passed in the calling lists.
zmconv_microp and the zm_microphysics are being removed with this PR as well. It was deemed that this implementation is not the correct way to embed the microphysics in ZM.
Closes #889