Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_3_146: ZM clean up in preparation for using via CCPP and remove zmconv_microp feature #890

Merged
merged 12 commits into from
Jan 23, 2024
4 changes: 2 additions & 2 deletions Externals_CAM.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ tag = ALI_ARMS_v1.0.0
required = True

[atmos_phys]
tag = atmos_phys0_00_011
tag = 7883a29d4c
protocol = git
repo_url = https://github.com/NCAR/atmospheric_physics
repo_url = https://github.com/cacraigucar/atmospheric_physics
nusbaume marked this conversation as resolved.
Show resolved Hide resolved
required = True
local_path = src/atmos_phys

Expand Down
1 change: 0 additions & 1 deletion bld/build-namelist
Original file line number Diff line number Diff line change
Expand Up @@ -3474,7 +3474,6 @@ if (!$simple_phys) {
add_default($nl, 'zmconv_ke');
add_default($nl, 'zmconv_ke_lnd');
add_default($nl, 'zmconv_org');
add_default($nl, 'zmconv_microp');
add_default($nl, 'zmconv_num_cin');
add_default($nl, 'zmconv_dmpdz');
add_default($nl, 'zmconv_tiedke_add');
Expand Down
6 changes: 6 additions & 0 deletions bld/configure
Original file line number Diff line number Diff line change
Expand Up @@ -1802,6 +1802,9 @@ if ($usr_cppdefs and $print>=2) { print "Commandline CPP definitions: \'$usr_cpp
# the CPP definitions that were explicitly set in the defaults file or by the user on the commandline.
my $cfg_cppdefs = ' ';

# Turn on CCPP "OLD_CAM"
$cfg_cppdefs .= " -DOLD_CAM";
cacraigucar marked this conversation as resolved.
Show resolved Hide resolved

# Building for perturbation growth tests
if ($pergro eq "ON") { $cfg_cppdefs .= " -DPERGRO"; }

Expand Down Expand Up @@ -2246,6 +2249,9 @@ sub write_filepath
# in the list of filepaths.
print $fh "$camsrcdir/src/physics/cam\n";

#Add the CCPP'ized subdirectories
print $fh "$camsrcdir/src/atmos_phys/zm\n";

# Dynamics package and test utilities
print $fh "$camsrcdir/src/dynamics/$dyn\n";
if($dyn eq 'se') {
Expand Down
1 change: 0 additions & 1 deletion bld/namelist_files/namelist_defaults_cam.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2767,7 +2767,6 @@
<zmconv_org > .false. </zmconv_org>
<zmconv_org zmconv_org="1" > .true. </zmconv_org>

<zmconv_microp > .false. </zmconv_microp>
<zmconv_num_cin > 5 </zmconv_num_cin>
<zmconv_num_cin phys="cam6" > 1 </zmconv_num_cin>
<zmconv_num_cin phys="cam_dev" > 1 </zmconv_num_cin>
Expand Down
6 changes: 0 additions & 6 deletions bld/namelist_files/namelist_definition.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3197,12 +3197,6 @@ if -zmconv_org is set in configure.
Default: .false., unless -zmconv_org set in configure
</entry>

<entry id="zmconv_microp" type="logical" category="conv"
group="zmconv_nl" valid_values="" >
Turn on convective microphysics
Default: .false.
</entry>

<entry id="zmconv_num_cin" type="integer" category="conv"
group="zmconv_nl" valid_values="" >
The number of negative buoyancy regions that are allowed before the convection top and CAPE calculations are completed.
Expand Down
10 changes: 0 additions & 10 deletions cime_config/testdefs/testlist_cam.xml
Original file line number Diff line number Diff line change
Expand Up @@ -519,16 +519,6 @@
<option name="wallclock">00:30:00</option>
</options>
</test>
<!-- 367 -->
<test compset="QPC6" grid="f10_f10_mg37" name="ERC_D_Ln9_Vnuopc" testmods="cam/outfrq3s_convmic">
<machines>
<machine name="izumi" compiler="nag" category="aux_cam"/>
</machines>
<options>
<option name="comment" >367 tsm, ter</option>
<option name="wallclock">00:30:00</option>
</options>
</test>
<!-- 368 -->
<test compset="QPC6" grid="f10_f10_mg37" name="ERC_D_Ln9_Vnuopc" testmods="cam/outfrq3s">
<machines>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading