cam6_3_145: New PUMAS External with adjusted vapor deposition onto snow #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrher
approved these changes
Dec 8, 2023
|
Requested re-review from Adam and initial review from @PeterHjortLauritzen . This is not for reviewing the code, but accepting the science changes which are coming in. |
adamrher
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Approved. based on latest science results NCAR/amwg_dev#445
cacraigucar
changed the title
peverwhee
changed the title
peverwhee
changed the title
cacraigucar
approved these changes
Jan 4, 2024
cacraigucar
added a commit
to cacraigucar/CAM
that referenced
this pull request
Jan 19, 2024
Merge pull request ESCOMP#938 from PUMASDevelopment/katetc/rainevap_pr
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
May 2, 2024
Merge pull request ESCOMP#938 from PUMASDevelopment/katetc/rainevap_pr cam6_3_145: New PUMAS External with adjusted vapor deposition onto snow Issue ESCOMP#936 - A one-line change in PUMAS resulting in a new tag for the external. This needs to be merged after the ML PR to cam_development (PR ESCOMP#858 ). resolves ESCOMP#936 Includes Cheryl's PR closes ESCOMP#948 Closes ESCOMP#947 Run to confirm the impact of this change is at: NCAR/amwg_dev#445 ESCOMP commit: 452cb5b
adamrher
added a commit
to adamrher/CAM
that referenced
this pull request
May 10, 2024
Merge pull request ESCOMP#938 from PUMASDevelopment/katetc/rainevap_pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #936 - A one-line change in PUMAS resulting in a new tag for the external. This needs to be merged after the ML PR to cam_development (PR #858 ).
resolves #936
Includes Cheryl's PR
closes #948
Closes #947
Run to confirm the impact of this change is at: NCAR/amwg_dev#445