cam6_3_144: New PUMAS external with machine learning support #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peverwhee
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Thanks for addressing all of @cacraigucar 's comments! I just have one small question in configure.
…MASDevelopment/CAM into katetc/machlrn_camdev_pr2_cac
|
Hi all, I also wanted to add a note that, currently, the "Emulated" option in the ML is not working. It was for a while with Cheryl's work and then some updates from the group broke it. The ML group are working on another update now that should fix it going forward. As I mentioned in a comment above, the code modification here are still early stages, and issues won't impact any other compset or configuration in CAM. I don't know if we will have the final changes before we get to the CAM tag, so there may be another PUMAS update in the next few weeks. |
nusbaume
requested changes
Dec 8, 2023
cacraigucar
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Resolved all @nusbaume conversations. Giving my final approval as well.
cacraigucar
changed the title
peverwhee
changed the title
peverwhee
changed the title
cacraigucar
reviewed
Jan 2, 2024
Katetc
added a commit
that referenced
this pull request
Jan 5, 2024
cam6_3_145: New PUMAS External with adjusted vapor deposition onto snow Issue #936 - A one-line change in PUMAS resulting in a new tag for the external. This needs to be merged after the ML PR to cam_development (PR #858 ). resolves #936 Includes Cheryl's PR closes #948 Closes #947 Run to confirm the impact of this change is at: NCAR/amwg_dev#445
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
May 2, 2024
Merge pull request ESCOMP#858 from PUMASDevelopment/katetc/machlrn_camdev_pr2_cac cam6_3_144: New PUMAS external with machine learning support ESCOMP commit: 0ac715b
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
May 2, 2024
Merge pull request ESCOMP#938 from PUMASDevelopment/katetc/rainevap_pr cam6_3_145: New PUMAS External with adjusted vapor deposition onto snow Issue ESCOMP#936 - A one-line change in PUMAS resulting in a new tag for the external. This needs to be merged after the ML PR to cam_development (PR ESCOMP#858 ). resolves ESCOMP#936 Includes Cheryl's PR closes ESCOMP#948 Closes ESCOMP#947 Run to confirm the impact of this change is at: NCAR/amwg_dev#445 ESCOMP commit: 452cb5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary PR with the tag for PUMAS now including early support for a machine learning kernel.
Fixes #801