Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweeting fix #84

Merged
merged 6 commits into from
Jun 3, 2020
Merged

Tweeting fix #84

merged 6 commits into from
Jun 3, 2020

Conversation

nahuelhds
Copy link
Contributor

@nahuelhds nahuelhds commented May 25, 2020

This fix recovers the ability to start a thread lost at #77 after the change made by @andresfib of the default value from None to '' for the tweet_status_id_str columns.

@andresfib is this change actually needed? I don't see you use that column in your PR at all. Anyway, I've already change it to make it work again.

In the other hand, I've addede the magic props of url_changed, title_changed, summary_changed that I forgot to add to the Diff model. Those are used when all the lang terms are defined in order to build the text properly. I've just realized about that omission 🤦‍♂️

Side note

It also includes a Travis CI fix as chrome stable version is now 83 and chromedriver at apt-get was 81 so I found a way to install the proper version in order for the CI to work again

@nahuelhds nahuelhds mentioned this pull request May 26, 2020
@andresfib
Copy link
Contributor

@nahuelhds , sorry for the mess after changing the default value.

I don't recall exactly, but I believe I changed it because peewee? was complaining that tweet_status_id_str is not initialized when not using twitter to publish diffs.

@nahuelhds
Copy link
Contributor Author

@nahuelhds , sorry for the mess after changing the default value.

I don't recall exactly, but I believe I changed it because peewee? was complaining that tweet_status_id_str is not initialized when not using twitter to publish diffs.

Weird. That was why I initially used the null=True definition. Anyway, now it follows your change and looks for tweet = '' and then creates the thread :)

@nahuelhds nahuelhds closed this Jun 2, 2020
@nahuelhds nahuelhds deleted the feature/tweetting-fix branch June 2, 2020 23:25
@nahuelhds nahuelhds restored the feature/tweetting-fix branch June 3, 2020 00:03
@nahuelhds nahuelhds reopened this Jun 3, 2020
@nahuelhds
Copy link
Contributor Author

@edsu this one is ready to be merged

@edsu edsu merged commit b9e4b82 into DocNow:master Jun 3, 2020
@nahuelhds nahuelhds deleted the feature/tweetting-fix branch June 3, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants