Add sendgrid support to send emails #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andresfib -- I think it would be good to mention this support in the README.md but I can add that. |
|
I will do the README, @edsu. And later maybe propose a reorganization. |
nahuelhds
added a commit
to nahuelhds/diffengine
that referenced
this pull request
May 25, 2020
This was referenced May 25, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendgrid can be set up as a handler for publishing diffs. I have not updated the README as it looks unwiedly. I have kept the changes to the twitter handler minimal, and functionality should not be affected.
tweet_status_id_str column in db is allowed to be empty now, as sendgrid does not set it up.
Refactoring to be discussed...