Configurable database #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahuelhds
force-pushed
the
feature/configurable-database
branch
from
46d8bbd to
7f168c8
Compare
# Conflicts: # diffengine/__init__.py # test_diffengine.py
|
@edsu this one is ready to be merged too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the database connection is handled with the
dbproperty directly and using URL database connections. If nodbprop is defined, the valuesqlite:///diffengine.dbis used in order to maintain compatibility.In order for this to work with PostgreSQL I've added
psycopg2-binary==2.8.5package. So, basically, with this feature the project has "native" support for Sqlite and PostgreSql. If any other engine is desired, then the proper package needs to be installed (MySQL or any other) and of course the proper database url string to be set as indicated in the peewee docsThe postgre configuration requires usingThese ones were because of the?autorollback=trueat the end of the database url, in order to avoiding unwanted errorsemailedcolumn that my schema was missing after the changes in #77.I've updated the chromedriver in Travis CI in the PR #84 and I've cherry picked those commits for the CI to pass here too.
Non related
time.sleep(closes Maketime.sleepconfigurable and default to zero #76)