Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes report 3 #1043

Merged

Conversation

juandahl
Copy link

PR Description

Title: Fixes for Negative Withdrawal Amount, Residual Debt, Borrowing Failures, and APR Label Update

Overview:
This PR resolves several key issues in the lending pool:

Changes Made:

  • Withdrawal Amount Fix: Prevents negative values from displaying as the maximum withdrawable amount.
  • Residual Debt Elimination: Ensures no residual "dust" remains after full loan repayment.
  • ETH Borrowing Fix: Corrects issue causing ETH borrow transactions to fail.
  • Label Update: Changes "Supply APR" to "Supply APY" for accurate yield representation.

juandahl and others added 24 commits October 14, 2024 16:55
…AaveLendingHistoryFrame/AaveLendingHistoryFrame.constants.tsx

Co-authored-by: Pietro <[email protected]>
fix: change address and fix max button
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: b592422

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 31, 2024

👷 Deploy request for sovryn-dapp pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b592422

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for sovryn-storybook ready!

Name Link
🔨 Latest commit b592422
🔍 Latest deploy log https://app.netlify.com/sites/sovryn-storybook/deploys/6723a4c41b3b4300084a0bd7
😎 Deploy Preview https://deploy-preview-1043--sovryn-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pietro-maximoff pietro-maximoff marked this pull request as ready for review November 1, 2024 15:20
@pietro-maximoff pietro-maximoff merged commit 17ad88a into DistributedCollective:feat/money-market Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants