SAF-13 Withdraw components #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just updated to this: instead 
|
|
Also updated the base to |
njaume
reviewed
Aug 9, 2024
.../app/5_pages/AavePage/components/LendPositionsList/components/WithdrawModal/WithdrawForm.tsx
Outdated
Show resolved
Hide resolved
njaume
approved these changes
Aug 9, 2024
juandahl
approved these changes
Aug 9, 2024
...s/AavePage/components/LendPositionsList/components/LendPositionAction/LendPositionAction.tsx
Outdated
Show resolved
Hide resolved
.../app/5_pages/AavePage/components/LendPositionsList/components/WithdrawModal/WithdrawForm.tsx
Show resolved
Hide resolved
.../app/5_pages/AavePage/components/LendPositionsList/components/WithdrawModal/WithdrawForm.tsx
Show resolved
Hide resolved
…sList/components/LendPositionAction/LendPositionAction.tsx Co-authored-by: Juan Dahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: SAF-13
Implement withdraw modal UI with as many validations as possible at this stage.
Notes
Code style following
This PR builds on top of #1 so we should wait for that one to go in first
Demo
2024-08-09.16-26-27.mp4