Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAF-10 Implement borrow components #3

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

matzapata
Copy link

Overview

Jira ticket: SAF-10

Implement borrow modal UI with as many validations as possible at this stage.

Notes

Code style following

This PR builds on top of #1 so we should wait for that one to go in first

Demo

2024-08-09.17-59-44.mp4

@matzapata matzapata added the hold label Aug 9, 2024
@matzapata matzapata changed the title borrow form modal Implement borrow components Aug 9, 2024
@matzapata matzapata changed the title Implement borrow components SAF-10 Implement borrow components Aug 9, 2024
Copy link

@juandahl juandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a doubt about using memos. I would avoid them unless they use them on the project or we have a puntual feature too complex in terms of performance

@matzapata matzapata changed the base branch from static-ui-position-tables to develop August 9, 2024 18:08
@matzapata matzapata removed the hold label Aug 9, 2024
@matzapata matzapata merged commit 5fa3b69 into develop Aug 12, 2024
@matzapata matzapata deleted the SAF-10_borrow-components branch August 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants