Final delivery money market (includes the charts) #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sList/components/LendPositionAction/LendPositionAction.tsx Co-authored-by: Juan Dahl <[email protected]>
Static Dashboard UI
SAF-13 Withdraw components
SAF-10 Implement borrow components
SAF 15 repay components
Saf 37 lend components
#51) * coments * fix borrow power * fixes and cleanup * cleanup * refactor config for same code style and handle mainnet config * small fixes * remove unused files and fix repay with balance future collateral ratio
Co-authored-by: Pietro <[email protected]>
…ts/InterestRateModelGraph/components/Chart/Chart.utils.ts Co-authored-by: Pietro <[email protected]>
* [SAF_20] integrate charts data and api * [SAF_20] rewrite useAaveReservesHistory without using cancelable * [SAF_20] remove type * [SAF_20] remove jsdocs; use Decimal instead of number * [SAF_20] remove unnecesary variable calculatedDate ; replace native fetch by axios * [SAF_20] remove comments * [SAF_20] move 18,27 decimals constants to math; move abi to constant file and remove unnecesary fields * [SAF_20] use getProvider with bob chain id * [SAF_20] remove unnecesary typed expression * [SAF-20] add use memo * [SAF-20] remove redundant use of loading * [SAF-20] remove let by const * [SAF-20] refactor supply and borrow chart data setup * [SAF-20] refactor useRate giving symbol as a paramter * [SAF-20] add manually time controls to charts (#52) * [SAF-20] add manually time controls to charts * [SAF-20] use enum from history hook to type TimeRangeButtons * [SAF-20] replace color codes by theme variables * [SAF-20] translate rate results from string to Decimal type ; delete unnecesary contract for the rate calculation that was introduced for reading getStableRateExcessOffset and OPTIMAL_STABLE_TO_TOTAL_DEBT_RATIO * [SAF-20] rebase develop; resolve conflicts * [SAF-20] rename text variable * [SAF-20] fix calculation of utilization ratio * [SAF-20] integrate REACT_APP_RATES_HISTORY_API_URL * [SAF-20] improve calculateUtilizationRate * [SAF-20] extract calculateUtilizationRate to util file; add check for value between zero and one ; add tests * Update .env.example * [SAF-20] remove unnecesary WEI def * [SAF-20] wrapp describes * [SAF-20] map values into Decimal * [SAF-20] fix building reserve address * [SAF-20] remove comment about a possible BUG; doesnt apply * [SAF-20] move checkinig isBetweenZeroAndOne to inner function calculateUtilizationRate and return Zero in that case * [SAF-20] rename parameter * [SAF-20] move URL to constants * [SAF-20] remove useless comments * [SAF-20] add missing useCallback * [SAF-20] rename parameter * [SAF-20] remove isBetweenZeroAndOne leave the check inside calculation; move calculateUtilizationRate into AaveCalculations class * [SAF-20] Use the same naming convention for RatesHistoryApiUrl as the rest of the constants * [SAF-20] simplify hook useAaveRates with just one memo hook * [SAF-20] simplify history data by removing unused utilizationRate and stableBorrowRate ; return just a type number to avoid unnecesary conversions * [SAF-20] use Decimal to calculate interest rates
👷 Deploy request for sovryn-dapp pending review.Visit the deploys page to approve it
|
|
✅ Deploy Preview for sovryn-storybook canceled.
|
pietro-maximoff
requested changes
Sep 13, 2024
...5_pages/AaveReserveOverviewPage/components/InterestRateModelGraph/InterestRateModelGraph.tsx
Outdated
Show resolved
Hide resolved
...5_pages/AaveReserveOverviewPage/components/InterestRateModelGraph/InterestRateModelGraph.tsx
Show resolved
Hide resolved
...5_pages/AaveReserveOverviewPage/components/InterestRateModelGraph/InterestRateModelGraph.tsx
Outdated
Show resolved
Hide resolved
| if (!signer) { | ||
| return null; | ||
| } | ||
| if (!signer) return null; |
There was a problem hiding this comment.
it doesn't need to be changed
| if (!signer) { | ||
| return null; | ||
| } | ||
| if (!signer) return null; |
There was a problem hiding this comment.
it doesn't need to be changed
| if (!signer) { | ||
| return null; | ||
| } | ||
| if (!signer) return null; |
There was a problem hiding this comment.
it doesn't need to be changed
| if (!signer) { | ||
| return null; | ||
| } | ||
| if (!signer) return null; |
There was a problem hiding this comment.
it doesn't need to be changed
pietro-maximoff
approved these changes
Sep 13, 2024
pietro-maximoff
merged commit 42a7342
into
DistributedCollective:feat/money-market
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sovryn.atlassian.net/browse/SOV-4386