Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Margintrading using limitorder #404

Merged
merged 27 commits into from
Apr 20, 2022
Merged

Margintrading using limitorder #404

merged 27 commits into from
Apr 20, 2022

Conversation

smbsp
Copy link
Contributor

@smbsp smbsp commented Dec 15, 2021

Modified the marginTrade() function to address the issue when setting Limit Orders using the collateral currency.

More Details Here: https://docs.google.com/spreadsheets/d/1vRZ-ZpBiCr7RXM5gc2EM1qOY7Wm369yNW9lP8K4ifKY/edit#gid=0

@smbsp smbsp changed the base branch from development to rubicon-deployment December 15, 2021 12:48
@smbsp smbsp self-assigned this Dec 15, 2021
Base automatically changed from rubicon-deployment to development January 12, 2022 12:40
@smbsp smbsp requested a review from Alitasovryn January 26, 2022 12:02
ororopickpocket
ororopickpocket requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@ororopickpocket ororopickpocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic looks good. small comments.

contracts/connectors/loantoken/LoanTokenLogicStandard.sol Outdated Show resolved Hide resolved
tests/loan-token/TradingTestToken.test.js Outdated Show resolved Hide resolved
@Alitasovryn
Copy link

Reviewed the test cases and tests are passing.

@smbsp smbsp requested a review from ororopickpocket February 2, 2022 13:05
@smbsp smbsp merged commit 41115d7 into development Apr 20, 2022
@smbsp smbsp deleted the margintrading-using-limitorder branch April 20, 2022 12:06
@tjcloa tjcloa mentioned this pull request May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eMarchenko eMarchenko eMarchenko left review comments

@Alitasovryn Alitasovryn Alitasovryn approved these changes

@ororopickpocket ororopickpocket Awaiting requested review from ororopickpocket

Assignees

@smbsp smbsp

Labels
medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smbsp @Alitasovryn @eMarchenko @ororopickpocket