Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margintrading using limitorder #404

Merged
merged 27 commits into from
Apr 20, 2022
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
955601c
Modified marginTrade()
smbsp Dec 14, 2021
d551c2f
Ran Prettier
smbsp Dec 14, 2021
51f2d08
Modified the logic to check position size
smbsp Dec 16, 2021
90afb73
Ran Prettier
smbsp Dec 16, 2021
b6e0701
Modified the legacy 'minReturn' parameter
smbsp Dec 16, 2021
fc5e448
Merge branch 'development' of https://github.com/DistributedCollectiv…
smbsp Jan 19, 2022
5ac2d54
Ran Prettier
smbsp Jan 19, 2022
9bb0ca2
Fixed failing test
smbsp Jan 19, 2022
d0f432b
Merge branch 'development' of https://github.com/DistributedCollectiv…
smbsp Jan 21, 2022
f3e4d75
Fixed Typo
smbsp Jan 21, 2022
9231303
Fixed script and updated addresses
smbsp Jan 21, 2022
d226c8c
Ran prettier
smbsp Jan 21, 2022
a4b17a9
Merge branch 'development' of https://github.com/DistributedCollectiv…
smbsp Jan 21, 2022
f5682fd
Merge branch 'development' of https://github.com/DistributedCollectiv…
smbsp Feb 2, 2022
d7ff47e
Ran prettier
smbsp Feb 2, 2022
fd84c97
Incorporating review comments
smbsp Feb 2, 2022
29f5194
Ran prettier
smbsp Feb 2, 2022
2d69e9d
Updated addresses
smbsp Feb 2, 2022
371b63b
Ran prettier
smbsp Feb 2, 2022
20ca32d
Merge branch 'development' of https://github.com/DistributedCollectiv…
smbsp Feb 3, 2022
6286c57
Ran prettier
smbsp Feb 3, 2022
897b8b0
Changed variable name
smbsp Feb 16, 2022
8a431e0
Merge branch 'development' of https://github.com/DistributedCollectiv…
smbsp Feb 16, 2022
3c67fbd
Ran Prettier
smbsp Feb 16, 2022
0a000da
Modified Prettier
smbsp Apr 20, 2022
29a104c
Merge branch 'development' of https://github.com/DistributedCollectiv…
smbsp Apr 20, 2022
6fbef0f
Ran prettier
smbsp Apr 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed Typo
  • Loading branch information
smbsp committed Jan 21, 2022
commit f3e4d75a1368468f7f6b69f1df420e015508e6c4
2 changes: 1 addition & 1 deletion contracts/interfaces/ILoanTokenModules.sol
Original file line number Diff line number Diff line change
@@ -188,7 +188,7 @@ interface ILoanTokenModules {
function checkPriceDivergence(
uint256 loanTokenSent,
address collateralTokenAddress,
uint256 maxEntryPrice
uint256 minEntryPrice
) external view;

function getMaxEscrowAmount(uint256 leverageAmount) external view returns (uint256 maxEscrowAmount);