-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loan token enhancements v1.20.0 #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tjcloa
commented
May 6, 2022
•
edited
Loading
edited
- Modified the marginTrade() function to address the issue when setting Limit Orders using the collateral currency.
- Register missing function signature from loan token
- Change to use the whole converted loan token instead of the predefined input by user
- .prettier rules update and apply formatting
…e/Sovryn-smart-contracts into margintrading-using-limitorder
…e/Sovryn-smart-contracts into margintrading-using-limitorder
…e/Sovryn-smart-contracts into margintrading-using-limitorder
…e/Sovryn-smart-contracts into margintrading-using-limitorder
…e/Sovryn-smart-contracts into margintrading-using-limitorder
…e/Sovryn-smart-contracts into margintrading-using-limitorder
when used collateral to extend the loan duration, will use the whole converted loan token
…nd_duration fix: money lost on extendLoanDuration
Sip-0044-voting
This reverts commit 778e41b.
…entation-pep8 .prettier update useTabs: false, printWidth: 99
…e/Sovryn-smart-contracts into margintrading-using-limitorder
…g-limitorder Margintrading using limitorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.