-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change layout back to be relative #6
change layout back to be relative #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It would be nice to get the generated tests working again. The position being relative fixes the re-layout movement issue #2 fixed, and it is trivial for any downstream crate to get the absolute position, if they want it.
Thank You!
|
change layout back to be relative
Revert #2 and vislyhq/stretch#87
The test from #2 is still present and still successful.
With those two PRs, the value returned for location is the absolute value. Without, the value is relative to its parent.
The test expect the value to be relative, as for example in this test:
https://github.com/DioxusLabs/stretch/blob/02033c0e8f52c9d12c40557804162eadd3f8a3a2/tests/generated/flex_basis_slightly_smaller_then_content_with_flex_grow_large_size.rs#L77-L84
where
node10
has a location.x of 0 even though its parentnode1
has a location.x of 80This PR makes it work OK for Bevy again