fix re-computing layout moves children of non-zero positioned parent #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
I think I understand this now, and this is a way better optimization than what was there originally. Thank you! |
nicoburns
referenced
this pull request
in nicoburns/taffy
Sep 13, 2022
jkelleyrtp
added a commit
that referenced
this pull request
Oct 10, 2022
fix re-computing layout moves children of non-zero positioned parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calling compute_layout on a tree where some element is a child of an element whose position is non-zero will move the child.
round_layout rounds the layout and calculates the position of children and is called every time compute is called. When the layout is cached round_layout is called a second time, and adds the parent's position to the child again, causing the movement.