Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook build issue #3380

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Conversation

himself65
Copy link
Member

Jack-Works
Jack-Works previously approved these changes Jun 16, 2021
guanbinrui
guanbinrui previously approved these changes Jun 17, 2021
@himself65 himself65 dismissed stale reviews from guanbinrui and Jack-Works via 1d77d7a June 21, 2021 07:17
Jack-Works
Jack-Works previously approved these changes Jun 21, 2021
@septs septs changed the base branch from master to develop June 23, 2021 08:38
@septs septs dismissed Jack-Works’s stale review June 23, 2021 08:38

The base branch was changed.

@septs septs changed the title chore: fix storybook build issue fix: storybook build issue Jun 23, 2021
@septs septs changed the title fix: storybook build issue fix: storybook build issue Jun 23, 2021
guanbinrui
guanbinrui previously approved these changes Jun 24, 2021
@himself65 himself65 force-pushed the storybook-fix branch 3 times, most recently from 0ec5f27 to f226e11 Compare June 24, 2021 05:19
Jack-Works
Jack-Works previously approved these changes Jun 24, 2021
@septs
Copy link
Contributor

septs commented Jun 28, 2021

@himself65 plz resolve conflict.

@Jack-Works Jack-Works merged commit 393e53f into DimensionDev:develop Jun 28, 2021
yanzhihong23 added a commit that referenced this pull request Jul 1, 2021
* develop: (25 commits)
  chore: set gh-actions name (#3542)
  Hotfix/1.33.2 to develop (#3537)
  chore: github bot auto add conflict label to pr (#3539)
  fix: add notistack for theme (#3534)
  feat: add new token selector and  show balance (#3482)
  feat: ITO lazy load history list (#3524)
  chore: clean blob (#3528)
  chore: clean file reader (#3527)
  feat: migrate VCent plugin to new plugin infra (#3497)
  chore: remove unused code (#3525)
  fix: handle change (#3523)
  fix: file service label (#3526)
  feat: migrate Transak plugin to new plugin infra (#3496)
  chore: clean event bound (#3522)
  refactor: ito new proxy contract (#3487)
  feat: migrate Polls plugin to new plugin infra (#3500)
  chore: clean jsx (#3520)
  chore: fix storybook build issue (#3380)
  refactor: remove web3-shared dependency in shared package (#3519)
  chore: update github bot configuration (#3516)
  ...
Jack-Works added a commit that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demand] Track upstream fix about "(tag.text || "").trim is not a function"
4 participants