Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demand] Track upstream fix about "(tag.text || "").trim is not a function" #3307

Closed
Jack-Works opened this issue Jun 7, 2021 · 6 comments · Fixed by #3308 or #3380
Closed

[Demand] Track upstream fix about "(tag.text || "").trim is not a function" #3307

Jack-Works opened this issue Jun 7, 2021 · 6 comments · Fixed by #3308 or #3380
Labels
Type: Bug

Comments

@Jack-Works
Copy link
Member

TypeError: (tag.text || "").trim is not a function

IMO @himself65 know how to fix this right?
@himself65
Copy link
Member

Related: #3256

@Jack-Works Jack-Works mentioned this issue Jun 8, 2021
Merged
@Jack-Works
Copy link
Member Author

cc @himself65 undo this when a new version that contains styleguidist/react-docgen-typescript#360 has released

@Jack-Works
Copy link
Member Author

https://github.com/styleguidist/react-docgen-typescript/releases/tag/v2.0.0

has published cc @himself65

@himself65
Copy link
Member

himself65 commented Jun 10, 2021 •
edited
Loading

yeah, the v2 has published however, we use @storybook/react which is upstream of it and haven't published the correct version

@himself65
Copy link
Member

Blocking because of storybookjs/storybook#15067

@Jack-Works Jack-Works reopened this Jun 10, 2021
@Jack-Works Jack-Works changed the title [Bug] Storybook fails on Netlify [Demand] Track upstream fix about "(tag.text || "").trim is not a function" Jun 10, 2021
@himself65
Copy link
Member

storybookjs/storybook#15067 (comment)

himself65 added a commit to himself65/Maskbook that referenced this issue Jun 16, 2021
@himself65
chore: fix storybook build issue
4b8fc4e 
Fixes: DimensionDev#3307
Related: storybookjs/storybook#15067
@himself65 himself65 mentioned this issue Jun 16, 2021
Merged
himself65 added a commit to himself65/Maskbook that referenced this issue Jun 21, 2021
@himself65
chore: fix storybook build issue
1d77d7a 
Fixes: DimensionDev#3307
Related: storybookjs/storybook#15067
himself65 added a commit to himself65/Maskbook that referenced this issue Jun 24, 2021
@himself65
chore: fix storybook build issue
2c2af49 
Fixes: DimensionDev#3307
Related: storybookjs/storybook#15067
himself65 added a commit to himself65/Maskbook that referenced this issue Jun 24, 2021
@himself65
chore: fix storybook build issue
0ec5f27 
Fixes: DimensionDev#3307
Related: storybookjs/storybook#15067
himself65 added a commit to himself65/Maskbook that referenced this issue Jun 24, 2021
@himself65
chore: fix storybook build issue
f226e11 
Fixes: DimensionDev#3307
Related: storybookjs/storybook#15067
himself65 added a commit to himself65/Maskbook that referenced this issue Jun 24, 2021
@himself65
chore: fix storybook build issue
0c46ca6 
Fixes: DimensionDev#3307
Related: storybookjs/storybook#15067
Jack-Works added a commit that referenced this issue Jun 28, 2021
@himself65 @Jack-Works
chore: fix storybook build issue (#3380)
393e53f 
Fixes: #3307
Related: storybookjs/storybook#15067

Co-authored-by: Jack Works <[email protected]>
Jack-Works added a commit that referenced this issue Jul 15, 2021
@himself65 @Jack-Works
chore: fix storybook build issue (#3380)
07c295c 
Fixes: #3307
Related: storybookjs/storybook#15067

Co-authored-by: Jack Works <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
2 participants
@Jack-Works @himself65