feat: ITO lazy load history list #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septs
reviewed
Jun 30, 2021
Jack-Works
reviewed
Jun 30, 2021
| import { useLayoutEffect, RefObject, useCallback } from 'react' | ||
| import { debounce } from 'lodash-es' | ||
|
|
||
| export function useScrollBottomEvent(ref: RefObject<HTMLDivElement>, cb: () => void) { |
There was a problem hiding this comment.
I recommend using https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver.
There was a problem hiding this comment.
Append an element at the bottom of the container, as it appears trigger the event. Maybe this is a little bit complex than the current implementation.
There was a problem hiding this comment.
To use IntersectionObserver, we also add a new element at the bottom and observe its distance to the viewport. It's better than watching scroll event and calculate the distance by yourself.
You can use this: https://github.com/streamich/react-use/blob/master/docs/useIntersection.md
|
Test passed with build (29769) |
septs
approved these changes
Jun 30, 2021
nuanyang233
approved these changes
Jun 30, 2021
yanzhihong23
added a commit
that referenced
this pull request
Jul 1, 2021
* develop: (25 commits) chore: set gh-actions name (#3542) Hotfix/1.33.2 to develop (#3537) chore: github bot auto add conflict label to pr (#3539) fix: add notistack for theme (#3534) feat: add new token selector and show balance (#3482) feat: ITO lazy load history list (#3524) chore: clean blob (#3528) chore: clean file reader (#3527) feat: migrate VCent plugin to new plugin infra (#3497) chore: remove unused code (#3525) fix: handle change (#3523) fix: file service label (#3526) feat: migrate Transak plugin to new plugin infra (#3496) chore: clean event bound (#3522) refactor: ito new proxy contract (#3487) feat: migrate Polls plugin to new plugin infra (#3500) chore: clean jsx (#3520) chore: fix storybook build issue (#3380) refactor: remove web3-shared dependency in shared package (#3519) chore: update github bot configuration (#3516) ...
Jack-Works
pushed a commit
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3414
lazy.load.list.mov