-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Hotfix 1.33.1 => 1.33.2 (patch) (1 of 2) #3352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2021
* fix: reset gas price reset gas price when leave tx confirm dialog or send the tx * chore: little fix * chore: only on eth mainnet
Co-authored-by: Septs <[email protected]>
* fix: firefox does not connect correctly close jira-42 * Update packages/maskbook/src/extension/background-script/EthereumServices/send.ts Co-authored-by: guanbinrui <[email protected]> Co-authored-by: guanbinrui <[email protected]>
…3411) * fix: ito configured data will not be cleared after close ITO dialog * chore: solve conflict Co-authored-by: Hancheng Zhou <[email protected]>
Jack-Works
approved these changes
Jun 20, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]>
* feat: ITO bsc polygon history * fix: ui * share dialog style * token symbol * fix: ui * fix: variable Co-authored-by: guanbinrui <[email protected]> Co-authored-by: guanbinrui <[email protected]>
* fix: thegraph query amount limit * chore: reply code review
* fix: the create button is unable to click, press enter key to create * Apply suggestions from code review Co-authored-by: Septs <[email protected]>
* chore: update weth address * refactor: move chain state to wallet plugin * chore: add useStartWatchChainState * fix: fetch balance if wallet is just created * refactor: batch requests * refactor: remove unused deps Co-authored-by: Jack Works <[email protected]> * refactor: reply reviews * fix: chain name Co-authored-by: Jack Works <[email protected]>
⚡ This PR is marked as ready. Preparing hotfix... |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3351
DO NOT push any commits to the
released
branch, any change on that branch will lost.Once the hotfix is ready, convert this PR from draft to ready.
Then, I'll tag the latest commit with "v1.33.2" and merge this automatically.
There is another PR point to the master branch to make sure patches are in the mainline.
This is the release PR for 1.33.2. To set a default template for the release PR, create a file ".github/HOTFIX-TEMPLATE.md". You can use $version to infer the new version.