fix: token icon not show on BSC #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
reviewed
Jun 16, 2021
packages/maskbook/src/extension/options-page/DashboardComponents/TokenIcon.tsx
Outdated
Show resolved
Hide resolved
guanbinrui
previously approved these changes
Jun 17, 2021
UncleBill
approved these changes
Jun 17, 2021
UncleBill
previously approved these changes
Jun 17, 2021
septs
reviewed
Jun 17, 2021
packages/maskbook/src/extension/options-page/DashboardComponents/TokenIcon.tsx
Outdated
Show resolved
Hide resolved
septs
changed the title
septs
reviewed
Jun 17, 2021
| @@ -40,41 +41,25 @@ const useStyles = makeStyles((theme: Theme) => ({ | |||
|
|
|||
| export interface TokenIconProps extends withClasses<never> { | |||
| name?: string | |||
| logoURL?: string | |||
| logoURI?: string | |||
guanbinrui
previously approved these changes
Jun 17, 2021
guanbinrui
approved these changes
Jun 18, 2021
guanbinrui
pushed a commit
that referenced
this pull request
Jun 21, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]>
Lanttcat
pushed a commit
that referenced
this pull request
Jun 23, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4)
Lanttcat
added a commit
that referenced
this pull request
Jun 23, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4)
Lanttcat
added a commit
that referenced
this pull request
Jun 23, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4)
Lanttcat
added a commit
that referenced
this pull request
Jun 29, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4)
Lanttcat
added a commit
that referenced
this pull request
Jun 29, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4)
Lanttcat
added a commit
that referenced
this pull request
Jun 30, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4)
Lanttcat
added a commit
that referenced
this pull request
Jun 30, 2021
* fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4)
guanbinrui
pushed a commit
that referenced
this pull request
Jun 30, 2021
* feat: add searchable list component in theme package * fix: token icon not show on BSC (#3383) * fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4) * feat: add token list component in dashboard package * chore: migrate useERC20TokensDetailedFromTokenLists to web3-shared * chore: @DimensionDev to @masknet * chore: fix pr comments * fix: rename TokenIconSpeialIconList to TokenIconSpecialIconList * fix: remove invalid style * fix: use currySameAddress in token icon to compare token address * chore: move TokenList and TokenIcon to share * chore: remove unused useImageFailOver hook * chore: move ErrorBoundary / QRCode / locales / useSnackbarCallback to shared from them * fix: work around for cannot be named without a reference * chore: remove unused package * refactor: use deconstruction for getTokenAssetBaseURLConstants in token icon * refactor: add interface NetworkSettings in setting * fix: fix prettier * refactor: use deconstruction for constant * refactor: rename token list props * fix: merge develop * refactor: add comment for token icon load * refactor: rename searchable list props to item keys to avoid react remove key * chore: remove useless code Co-authored-by: Jack Works <[email protected]>
Jack-Works
added a commit
that referenced
this pull request
Jul 15, 2021
* feat: add searchable list component in theme package * fix: token icon not show on BSC (#3383) * fix: change asset base url of binance token icon * fix: fetch token icon uri from mask.json * fix: perfect token icon map for missing in trust wallet and logoURI 404 * refactor: use isSameAddress to compare addresses in TokenIcon * chore: move special icon list to json file (#3402) * fix: typo error * fix: should use incoming chainId when get token asset base uri Co-authored-by: Septs <[email protected]> (cherry picked from commit 976f5f4) * feat: add token list component in dashboard package * chore: migrate useERC20TokensDetailedFromTokenLists to web3-shared * chore: @DimensionDev to @masknet * chore: fix pr comments * fix: rename TokenIconSpeialIconList to TokenIconSpecialIconList * fix: remove invalid style * fix: use currySameAddress in token icon to compare token address * chore: move TokenList and TokenIcon to share * chore: remove unused useImageFailOver hook * chore: move ErrorBoundary / QRCode / locales / useSnackbarCallback to shared from them * fix: work around for cannot be named without a reference * chore: remove unused package * refactor: use deconstruction for getTokenAssetBaseURLConstants in token icon * refactor: add interface NetworkSettings in setting * fix: fix prettier * refactor: use deconstruction for constant * refactor: rename token list props * fix: merge develop * refactor: add comment for token icon load * refactor: rename searchable list props to item keys to avoid react remove key * chore: remove useless code Co-authored-by: Jack Works <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3305