fix: firefox does not connect correctly close jira-42 #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
guanbinrui,
jk234ert,
septs and
zhouhanseng
guanbinrui
reviewed
Jun 18, 2021
packages/maskbook/src/extension/background-script/EthereumServices/send.ts
Outdated
Show resolved
Hide resolved
…ices/send.ts Co-authored-by: guanbinrui <[email protected]>
septs
reviewed
Jun 18, 2021
Tedko
approved these changes
Jun 19, 2021
|
And this should be picked in to the next release |
guanbinrui
added a commit
that referenced
this pull request
Jun 20, 2021
* fix: firefox does not connect correctly close jira-42 * Update packages/maskbook/src/extension/background-script/EthereumServices/send.ts Co-authored-by: guanbinrui <[email protected]> Co-authored-by: guanbinrui <[email protected]>
guanbinrui
added a commit
that referenced
this pull request
Jun 29, 2021
* fix: firefox does not connect correctly close jira-42 * Update packages/maskbook/src/extension/background-script/EthereumServices/send.ts Co-authored-by: guanbinrui <[email protected]> Co-authored-by: guanbinrui <[email protected]>
guanbinrui
added a commit
that referenced
this pull request
Jun 29, 2021
* chore: bump version from 1.33.1 to 1.33.2 * refactor: remove useless code * feat: transaction fee ui (#3321) * fix: reset gas price (#3390) * fix: reset gas price reset gas price when leave tx confirm dialog or send the tx * chore: little fix * chore: only on eth mainnet * fix: firefox does not connect correctly close jira-42 (#3413) * fix: firefox does not connect correctly close jira-42 * Update packages/maskbook/src/extension/background-script/EthereumServices/send.ts Co-authored-by: guanbinrui <[email protected]> Co-authored-by: guanbinrui <[email protected]> * fix: ito configured data will not be cleared after close ITO dialog (#3411) * fix: ito configured data will not be cleared after close ITO dialog * chore: solve conflict Co-authored-by: Hancheng Zhou <[email protected]> * fix: the text on welcome page can not display fully with small window width (#3410) * fix: user can create persona by more than 24 characters (#3408) * fix: clear poolSettings crash (#3442) * fix: is switchable (close #3423) * feat: ITO bsc polygon history (#3421) * feat: ITO bsc polygon history * fix: ui * share dialog style * token symbol * fix: ui * fix: variable Co-authored-by: guanbinrui <[email protected]> Co-authored-by: guanbinrui <[email protected]> * fix: import path * fix: should dependency urls and suffix when useAsync in useImageFailover (#3473) * fix: unlimit thegraph query amount (#3391) * fix: thegraph query amount limit * chore: reply code review * fix: user can create persona by more than 24 characters (#3477) * fix: the create button is unable to click, press enter key to create * Apply suggestions from code review Co-authored-by: Septs <[email protected]> * refactor: reduce block number queries (#3511) * chore: update weth address * refactor: move chain state to wallet plugin * chore: add useStartWatchChainState * fix: fetch balance if wallet is just created * refactor: batch requests * refactor: remove unused deps Co-authored-by: Jack Works <[email protected]> * refactor: reply reviews * fix: chain name Co-authored-by: Jack Works <[email protected]> * fix: lint error Co-authored-by: maskbook-maintainer-bot[bot] <66122279+maskbook-maintainer-bot[bot]@users.noreply.github.com> Co-authored-by: guanbinrui <[email protected]> Co-authored-by: Jack Works <[email protected]> Co-authored-by: guanbinrui <[email protected]> Co-authored-by: lelenei <[email protected]> Co-authored-by: Hancheng Zhou <[email protected]> Co-authored-by: Lantt <[email protected]> Co-authored-by: Septs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes jira-42