Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Use ophyd edge detection on i03 #863

Closed
DominicOram opened this issue Aug 18, 2023 · 3 comments
Closed

Use ophyd edge detection on i03 #863

DominicOram opened this issue Aug 18, 2023 · 3 comments
Assignees
@DominicOram

Comments

@DominicOram
Copy link
Collaborator

As of DiamondLightSource/dodal#143 we can do pin tip centring in ophyd instead of EPICS. We should soak test this on i03.

Acceptance Criteria

  • It is possible to switch between ophyd and EPICS edge detection implementations for the pin tip centring algorithms
  • This switch can be done via a property in GDA
  • A preliminary test is done with this on i03
@DominicOram
Copy link
Collaborator Author

Need to change switch to be a property and soak test

@DominicOram DominicOram mentioned this issue Nov 10, 2023
Closed
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Jan 12, 2024
@DominicOram
(DiamondLightSource/hyperion#863) Make new pin tip detection more sim…
f3a915a 
…ilar to old one
DominicOram added a commit that referenced this issue Jan 12, 2024
@DominicOram
(#863) Clean up setting up different pin tip detection devices
8475ca1
@DominicOram DominicOram self-assigned this Jan 14, 2024
DominicOram added a commit that referenced this issue Jan 14, 2024
@DominicOram
(#863) Always configure the AD plugin
7f9a0bc
DominicOram added a commit that referenced this issue Jan 14, 2024
@DominicOram
(#863) Add parameter for how to run pin tip detection
cbf7968
DominicOram added a commit that referenced this issue Jan 14, 2024
@DominicOram
(#863) Add tests for running ophyd pin tip detection device
424d75f
DominicOram added a commit that referenced this issue Jan 14, 2024
@DominicOram
(#863) Update dodal dependency
9f64032
@DominicOram DominicOram mentioned this issue Jan 14, 2024
Merged
2 tasks
DominicOram added a commit that referenced this issue Jan 14, 2024
@DominicOram
(#863) Fix typing issues
285b544
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Jan 14, 2024
@DominicOram
(DiamondLightSource/hyperion#863) Fix typing issues
16962ce
DominicOram added a commit that referenced this issue Jan 14, 2024
@DominicOram
(#863) Update dodal
3dff9a9
@DominicOram
Copy link
Collaborator Author

Waiting on https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/40986

@DominicOram
Copy link
Collaborator Author

Gerrit change merged, closing this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicOram DominicOram

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DominicOram