Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ophyd pin tip centre device more like the AD one #289

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

DominicOram
Copy link
Contributor

See DiamondLightSource/hyperion#863

Instructions to reviewer on how to test:

  1. Confirm tests pass and that the new pin tip detection device is more similar to the old one

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02d4299) 89.95% compared to head (16962ce) 89.98%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   89.95%   89.98%   +0.03%     
==========================================
  Files          82       82              
  Lines        3055     3055              
==========================================
+ Hits         2748     2749       +1     
+ Misses        307      306       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DominicOram DominicOram merged commit 15fc272 into main Jan 22, 2024
16 checks passed
@DominicOram DominicOram deleted the hyperion_863_use_ophyd_pin_tip branch January 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants