Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(status-api): Status API for Oracles #1315

Merged
merged 16 commits into from
Apr 20, 2022
Merged

Conversation

nichellekoh
Copy link
Contributor

What this PR does / why we need it:

This includes the status api to return the status of each oracles
operational: <= 15 mins
outage: > 15 mins

Which issue(s) does this PR fixes?:

Part of #1274

Additional comments?:

@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit c020a92
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/625ed24e591a580008668aa1
😎 Deploy Preview https://deploy-preview-1315--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Apr 4, 2022

Code Climate has analyzed commit c020a92 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@nichellekoh nichellekoh marked this pull request as draft April 4, 2022 10:32
@nichellekoh nichellekoh force-pushed the joeldavidw/status-oracles branch from df1a729 to f39f051 Compare April 4, 2022 13:22
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1315 (c020a92) into main (6d2148f) will increase coverage by 3.90%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   84.77%   88.68%   +3.90%     
==========================================
  Files         349      351       +2     
  Lines       10062    10115      +53     
  Branches     1238     1243       +5     
==========================================
+ Hits         8530     8970     +440     
+ Misses       1444     1071     -373     
+ Partials       88       74      -14     
Impacted Files Coverage Δ
...atus-api/src/controllers/OracleStatusController.ts 95.65% <95.65%> (ø)
apps/status-api/src/modules/ControllerModule.ts 100.00% <100.00%> (ø)
apps/whale/src/module.api/oracle.controller.ts 44.00% <100.00%> (ø)
.../src/module.indexer/model/dftx/update.pool.pair.ts 50.00% <0.00%> (-50.00%) ⬇️
...core/src/saga/AddressParser/dftx/AccountToUtxos.ts 62.50% <0.00%> (-37.50%) ⬇️
...src/module.indexer/model/dftx/resign.masternode.ts 84.21% <0.00%> (-15.79%) ⬇️
packages/jellyfish-api-core/src/category/mining.ts 84.61% <0.00%> (-15.39%) ⬇️
...transaction-builder/src/txn/txn_builder_account.ts 94.59% <0.00%> (-5.41%) ⬇️
...ges/rich-list-core/src/saga/AddressParser/index.ts 92.85% <0.00%> (-3.58%) ⬇️
apps/rich-list-api/src/modules/QueueModule.ts 100.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2148f...c020a92. Read the comment docs.

@nichellekoh nichellekoh marked this pull request as ready for review April 4, 2022 14:28
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 3bb1a69

  • ghcr.io/defich/legacy-api:pr-1315
  • ghcr.io/defich/ocean-api:pr-1315
  • ghcr.io/defich/playground-api:pr-1315
  • ghcr.io/defich/status-api:pr-1315

@nichellekoh nichellekoh requested review from eli-lim and weiyuan95 April 5, 2022 07:26
Copy link
Contributor

@ivan-zynesis ivan-zynesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change suggestion for more explicit api response

apps/status-api/src/controllers/OracleStatusController.ts Outdated Show resolved Hide resolved
@nichellekoh nichellekoh force-pushed the joeldavidw/status-oracles branch from b9c21fd to 4d153e9 Compare April 6, 2022 08:42
@joeldavidw joeldavidw self-requested a review April 7, 2022 06:53
joeldavidw
joeldavidw previously approved these changes Apr 7, 2022
joeldavidw
joeldavidw previously approved these changes Apr 19, 2022
kodemon
kodemon previously approved these changes Apr 19, 2022
cwkang1998
cwkang1998 previously approved these changes Apr 19, 2022
@nichellekoh nichellekoh force-pushed the joeldavidw/status-oracles branch from d25e00c to 6b07497 Compare April 19, 2022 14:47
@nichellekoh nichellekoh force-pushed the joeldavidw/status-oracles branch from 3abba4a to 71f8044 Compare April 19, 2022 15:10
@nichellekoh nichellekoh force-pushed the joeldavidw/status-oracles branch from 5e15168 to c020a92 Compare April 19, 2022 15:16
@nichellekoh nichellekoh requested a review from fuxingloh April 19, 2022 15:41
Copy link
Contributor

@joeldavidw joeldavidw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@nichellekoh nichellekoh requested a review from cwkang1998 April 19, 2022 16:00
@nichellekoh nichellekoh merged commit 96f768e into main Apr 20, 2022
@nichellekoh nichellekoh deleted the joeldavidw/status-oracles branch April 20, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants