Update oracle address to path param

DeFiCh · Apr 19, 2022 · 6b07497 · 6b07497
1 parent 9bae90b
commit 6b07497
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/apps/status-api/__tests__/controllers/OracleStatusController.test.ts b/apps/status-api/__tests__/controllers/OracleStatusController.test.ts
@@ -15,27 +15,27 @@ afterAll(async () => {
 })
 
 describe('OracleStatusController - Status test', () => {
-  it('/oracles?address=<address> - should get operational', async () => {
+  it('/oracles?address=<address> - should get operational as last published < 45 mins ago', async () => {
     jest.spyOn(apiTesting.app.get(WhaleApiClient).oracles, 'getPriceFeed')
       .mockReturnValueOnce(getMockedOraclePriceFeed('df1qm7f2cx8vs9lqn8v43034nvckz6dxxpqezfh6dw', 5))
 
     const res = await apiTesting.app.inject({
       method: 'GET',
-      url: 'oracles?address=df1qm7f2cx8vs9lqn8v43034nvckz6dxxpqezfh6dw'
+      url: 'oracles/df1qm7f2cx8vs9lqn8v43034nvckz6dxxpqezfh6dw'
     })
     expect(res.json()).toStrictEqual({
       status: 'operational'
     })
     expect(res.statusCode).toStrictEqual(200)
   })
 
-  it('/oracles?address=<address> -should get outage', async () => {
+  it('/oracles?address=<address> - should get outage as last published >= 45 mins ago', async () => {
     jest.spyOn(apiTesting.app.get(WhaleApiClient).oracles, 'getPriceFeed')
       .mockReturnValueOnce(getMockedOraclePriceFeed('df1qcpp3entq53tdyklm5v0lnvqer4verr4puxchq4', 46))
 
     const res = await apiTesting.app.inject({
       method: 'GET',
-      url: 'oracles?address=df1qcpp3entq53tdyklm5v0lnvqer4verr4puxchq4'
+      url: 'oracles/df1qcpp3entq53tdyklm5v0lnvqer4verr4puxchq4'
     })
     expect(res.json()).toStrictEqual({
       status: 'outage'

diff --git a/apps/status-api/src/controllers/OracleStatusController.ts b/apps/status-api/src/controllers/OracleStatusController.ts
@@ -1,4 +1,4 @@
-import { Controller, Get, Query } from '@nestjs/common'
+import { Controller, Get, Param } from '@nestjs/common'
 import { WhaleApiClient } from '@defichain/whale-api-client'
 import { OraclePriceFeed } from '@defichain/whale-api-client/dist/api/Oracles'
 import { SemaphoreCache } from '../../../whale/src/module.api/cache/semaphore.cache'
@@ -19,9 +19,9 @@ export class OracleStatusController {
    * @param oracleAddress
    * @return {Promise<OracleStatus>}
    */
-  @Get()
+  @Get('/:address')
   async getOracleStatus (
-    @Query('address') oracleAddress: string
+    @Param('address') oracleAddress: string
   ): Promise<{ status: OracleStatus }> {
     const oraclePriceFeed: OraclePriceFeed = await this.cachedGet(`oracle-${oracleAddress}`, async () => {
       const oracle = await this.client.oracles.getOracleByAddress(oracleAddress)