Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(status-api): Update Blockchain Status API path #1318

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

nichellekoh
Copy link
Contributor

What this PR does / why we need it:

Standardise path with oracles as per #1315

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@defichain-bot defichain-bot added area/apps kind/refactor Non feature refactor change labels Apr 4, 2022
@codeclimate
Copy link

codeclimate bot commented Apr 4, 2022

Code Climate has analyzed commit b622082 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for jellyfish-defi ready!

Name Link
🔨 Latest commit b622082
🔍 Latest deploy log https://app.netlify.com/sites/jellyfish-defi/deploys/624af57159dbc200090a9607
😎 Deploy Preview https://deploy-preview-1318--jellyfish-defi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1318 (b622082) into main (b1fb347) will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
+ Coverage   89.74%   90.64%   +0.89%     
==========================================
  Files         337      337              
  Lines        9674     9674              
  Branches     1177     1177              
==========================================
+ Hits         8682     8769      +87     
+ Misses        945      862      -83     
+ Partials       47       43       -4     
Impacted Files Coverage Δ
...status-api/src/controllers/BlockchainController.ts 100.00% <ø> (ø)
...kages/playground-api-client/src/apis/Playground.ts 50.00% <0.00%> (-50.00%) ⬇️
apps/legacy-api/src/modules/WhaleApiModule.ts 45.83% <0.00%> (-45.84%) ⬇️
...ground-api/src/controllers/PlaygroundController.ts 71.42% <0.00%> (-28.58%) ⬇️
...nsaction-builder/src/txn/txn_builder_masternode.ts 80.00% <0.00%> (-20.00%) ⬇️
...ages/jellyfish-transaction/src/script/dftx/dftx.ts 98.50% <0.00%> (+1.49%) ⬆️
packages/jellyfish-api-core/src/category/wallet.ts 100.00% <0.00%> (+2.29%) ⬆️
...ckages/jellyfish-transaction/src/script/mapping.ts 98.00% <0.00%> (+2.66%) ⬆️
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <0.00%> (+4.47%) ⬆️
...ners/src/containers/RegTestContainer/Masternode.ts 97.19% <0.00%> (+5.60%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fb347...b622082. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit ce530d1

  • ghcr.io/defich/legacy-api:pr-1318
  • ghcr.io/defich/ocean-api:pr-1318
  • ghcr.io/defich/playground-api:pr-1318
  • ghcr.io/defich/status-api:pr-1318

@nichellekoh nichellekoh requested review from weiyuan95 and removed request for weiyuan95 April 5, 2022 07:24
Copy link

@weiyuan95 weiyuan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nichellekoh nichellekoh merged commit 76c0abe into main Apr 6, 2022
@nichellekoh nichellekoh deleted the nichellekoh/status-blockchain branch April 6, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps kind/refactor Non feature refactor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants