Add pagination support for listaccounthistory
#1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
requested review from
Bushstar,
Mixa84,
wafflespeanut,
prasannavl and
Jouzo
as code owners
Mixa84
reviewed
Dec 19, 2022
|
Ignore Jellyfish failure - flaky test. |
Mixa84
approved these changes
Jan 13, 2023
fuxingloh
pushed a commit
to BirthdayResearch/jellyfishsdk
that referenced
this pull request
Jan 19, 2023
…accounthistory` RPC (#1923) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: **Requirement:** Upcoming consortium transaction history page on [defiscan.live](https://defiscan.live/) requires a way to paginate the list of transactions among consortium members. **Issue:** Currently we only have `blockHeight` and `depth` based pagination/cursor which we're unable to use to address the requirement as it only cursor through blocks but not transactions., More info [here](#1868 (comment)). **Solution:** - Add index based pagination support. - Add multi transaction types filter support. - Add multi address filter support. Huge thanks to @shohamc1 for supporting me on defich/ain side, refer [defich/ain PR](DeFiCh/ain#1643) Signed-off-by: Dilshan Madushanka <[email protected]> Co-authored-by: Isaac Yong <[email protected]> Co-authored-by: Kven Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
listaccounthistorytxtypesargument to allow filtering multiple CustomTxTypesownerto be an array, returns results for all addresses in the array