Add multi-account and multi-TX filters to accounthistorycount
#1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
requested review from
Bushstar,
Mixa84,
wafflespeanut,
prasannavl and
Jouzo
as code owners
|
Ignore Jellyfish failure - flaky test. |
|
@shohamc1 Can we have just a short test which verify that multi-tx filters work? |
|
Waiting for #1643 to get merged so that we can use feature_listaccounthistory_multiaccountquery.py to test this. |
Mixa84
previously approved these changes
Jan 13, 2023
Bushstar
reviewed
Jan 13, 2023
|
Related Jellyfish PR: BirthdayResearch/jellyfishsdk#1943 |
Bushstar
previously approved these changes
Jan 16, 2023
fuxingloh
pushed a commit
to BirthdayResearch/jellyfishsdk
that referenced
this pull request
Jan 20, 2023
…rt for `accounthistorycount` RPC (#1943) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: As stated in the title, this PR adds support to `accounthistorycount` RPC to query with multiple txtypes/addresses. We need this because with the current implementation we're only allowed to fetch one address and/or one tx type at once thus needing to make multiple RPC calls if we need to query history count of multple txtypes/addresses. Refer: [Defich/ain PR](DeFiCh/ain#1666) Signed-off-by: Dilshan Madushanka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #1665